Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support
Date	2016-08-23 23:50 +0200
Message-ID	<s9rK2-1fM-9@gated-at.bofh.it> (permalink)
References	<rKjwm-3eA-5@gated-at.bofh.it> <rKjwn-3eA-39@gated-at.bofh.it> <s9qXE-H7-19@gated-at.bofh.it> <s9rK2-1fM-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 23, 2016 at 11:28:59PM +0200, Jan Glauber wrote:
> On Tue, Aug 23, 2016 at 10:57:25PM +0200, Wolfram Sang wrote:
> > On Wed, Jun 15, 2016 at 03:51:30PM +0200, Jan Glauber wrote:
> > > Add SMBUS alert interrupt support. For now only device tree is
> > > supported for specifying the alert. In case of ACPI an error
> > > is returned.
> > > 
> > > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> > 
> > What about 'select I2C_SMBUS' in Kconfig and skip all the ifdeffery?
> > 
> 
> Wouldn't that prevent a distribution that has I2C_HELPER_AUTO set
> from enabling the ThunderX i2c driver at all?

From commit e2ca307439fb9df922c3e8891289a2ac05812fb7:

...
Bus drivers which implement SMBus alert should select this option, so
in most cases this option is hidden and the user doesn't have to care
about it.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support Wolfram Sang <wsa@the-dreams.de> - 2016-08-23 23:00 +0200
  Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support Wolfram Sang <wsa@the-dreams.de> - 2016-08-23 23:50 +0200

csiph-web