Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1469868 > unrolled thread
| Started by | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| First post | 2016-08-25 08:50 +0200 |
| Last post | 2016-08-31 10:40 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Milo Kim <woogyom.kim@gmail.com> - 2016-08-25 08:50 +0200
Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-08-26 09:20 +0200
Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Milo Kim <woogyom.kim@gmail.com> - 2016-08-26 10:10 +0200
Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-08-27 00:30 +0200
Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Milo Kim <woogyom.kim@gmail.com> - 2016-08-31 10:40 +0200
| From | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| Date | 2016-08-25 08:50 +0200 |
| Subject | [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl |
| Message-ID | <s9WEa-5OW-7@gated-at.bofh.it> |
In H3, PA5 can be used as PWM and UART0. If the PWM is used, the console
UART should be moved to other port.
This patch enables UART1 pinctrl to support this case.
PA5: PWM
PG6, PG7: debug console
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 3a965fb..fdb6801 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -526,6 +526,13 @@
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
};
+ uart1_pins_a: uart1@0 {
+ allwinner,pins = "PG6", "PG7";
+ allwinner,function = "uart1";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
mmc0_pins_a: mmc0@0 {
allwinner,pins = "PF0", "PF1", "PF2", "PF3",
"PF4", "PF5";
--
1.9.1
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-08-26 09:20 +0200 |
| Message-ID | <sajAK-3Vt-5@gated-at.bofh.it> |
| In reply to | #1469868 |
[Multipart message — attachments visible in raw view] — view raw
Hi Milo,
On Thu, Aug 25, 2016 at 03:44:54PM +0900, Milo Kim wrote:
> In H3, PA5 can be used as PWM and UART0. If the PWM is used, the console
> UART should be moved to other port.
> This patch enables UART1 pinctrl to support this case.
>
> PA5: PWM
> PG6, PG7: debug console
>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 3a965fb..fdb6801 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -526,6 +526,13 @@
> allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> };
>
> + uart1_pins_a: uart1@0 {
> + allwinner,pins = "PG6", "PG7";
> + allwinner,function = "uart1";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +
Our policy is that we don't introduce new pinctrl nodes that are not
used by any board to avoid bloating the DT too much with unused nodes.
If you have a board using it, please submit that change as well.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| Date | 2016-08-26 10:10 +0200 |
| Message-ID | <sakn7-4qD-9@gated-at.bofh.it> |
| In reply to | #1470570 |
On 08/26/2016 04:10 PM, Maxime Ripard wrote:
>> + uart1_pins_a: uart1@0 {
>> > + allwinner,pins = "PG6", "PG7";
>> > + allwinner,function = "uart1";
>> > + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> > + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> > + };
>> > +
> Our policy is that we don't introduce new pinctrl nodes that are not
> used by any board to avoid bloating the DT too much with unused nodes.
>
> If you have a board using it, please submit that change as well.
OK, I agree.
However, this pinmux is only useful in case PA5 is assigned for PWM.
PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into
*.dts and disable it (status = "disabled"). Does it make sense?
Best regards,
Milo
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-08-27 00:30 +0200 |
| Message-ID | <saxNn-4Bu-3@gated-at.bofh.it> |
| In reply to | #1470590 |
[Multipart message — attachments visible in raw view] — view raw
Hi Milo,
On Fri, Aug 26, 2016 at 05:00:37PM +0900, Milo Kim wrote:
> On 08/26/2016 04:10 PM, Maxime Ripard wrote:
> >>+ uart1_pins_a: uart1@0 {
> >>> + allwinner,pins = "PG6", "PG7";
> >>> + allwinner,function = "uart1";
> >>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >>> + };
> >>> +
> >Our policy is that we don't introduce new pinctrl nodes that are not
> >used by any board to avoid bloating the DT too much with unused nodes.
> >
> >If you have a board using it, please submit that change as well.
>
> OK, I agree.
>
> However, this pinmux is only useful in case PA5 is assigned for PWM.
> PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into *.dts
> and disable it (status = "disabled"). Does it make sense?
I guess UART1 is either used or not used on that board. In the former
case, it should be enabled, in the latter, left out of the DTS
entirely.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| Date | 2016-08-31 10:40 +0200 |
| Message-ID | <sc9dU-5u-13@gated-at.bofh.it> |
| In reply to | #1470570 |
Hi Maxime,
On 08/26/2016 04:10 PM, Maxime Ripard wrote:
> Hi Milo,
>
> On Thu, Aug 25, 2016 at 03:44:54PM +0900, Milo Kim wrote:
>> In H3, PA5 can be used as PWM and UART0. If the PWM is used, the console
>> UART should be moved to other port.
>> This patch enables UART1 pinctrl to support this case.
>>
>> PA5: PWM
>> PG6, PG7: debug console
>>
>> Cc: Chen-Yu Tsai <wens@csie.org>
>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
>> ---
>> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
>> index 3a965fb..fdb6801 100644
>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
>> @@ -526,6 +526,13 @@
>> allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> };
>>
>> + uart1_pins_a: uart1@0 {
>> + allwinner,pins = "PG6", "PG7";
>> + allwinner,function = "uart1";
>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> + };
>> +
>
> Our policy is that we don't introduce new pinctrl nodes that are not
> used by any board to avoid bloating the DT too much with unused nodes.
>
> If you have a board using it, please submit that change as well.
UART1 was already added in sun8i-h3.dtsi, so I drop this change in v2.
Commit-ID: 966c11a3b5e4
Best regards,
Milo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web