Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl
Date	2016-08-26 09:20 +0200
Message-ID	<sajAK-3Vt-5@gated-at.bofh.it> (permalink)
References	<s9WEa-5OW-9@gated-at.bofh.it> <s9WEa-5OW-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Milo,

On Thu, Aug 25, 2016 at 03:44:54PM +0900, Milo Kim wrote:
> In H3, PA5 can be used as PWM and UART0. If the PWM is used, the console
> UART should be moved to other port.
> This patch enables UART1 pinctrl to support this case.
> 
> 	PA5: PWM
> 	PG6, PG7: debug console
> 
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 3a965fb..fdb6801 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -526,6 +526,13 @@
>  				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>  			};
>  
> +			uart1_pins_a: uart1@0 {
> +				allwinner,pins = "PG6", "PG7";
> +				allwinner,function = "uart1";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +

Our policy is that we don't introduce new pinctrl nodes that are not
used by any board to avoid bloating the DT too much with unused nodes.

If you have a board using it, please submit that change as well.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-08-26 09:20 +0200
  Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Milo Kim <woogyom.kim@gmail.com> - 2016-08-26 10:10 +0200
    Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-08-27 00:30 +0200
  Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Milo Kim <woogyom.kim@gmail.com> - 2016-08-31 10:40 +0200

csiph-web