Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1464898 > unrolled thread

Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus

Started byJoe Perches <joe@perches.com>
First post2016-08-18 04:40 +0200
Last post2016-08-18 09:20 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus Joe Perches <joe@perches.com> - 2016-08-18 04:40 +0200
    Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus Dave Young <dyoung@redhat.com> - 2016-08-18 08:50 +0200
      Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus "Zhou, Wenjian/周文剑"   <zhouwj-fnst@cn.fujitsu.com> - 2016-08-18 09:20 +0200

#1464898 — Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus

FromJoe Perches <joe@perches.com>
Date2016-08-18 04:40 +0200
SubjectRe: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus
Message-ID<s7lpn-1Lg-3@gated-at.bofh.it>
On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote:
> nr_cpus can help to save memory. So we should remind user of it.

trivia:
> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
[]
> @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel:
>  * Boot parameter "1" boots the dump-capture kernel into single-user
>    mode without networking. If you want networking, use "3".
>  
> -* We generally don' have to bring up a SMP kernel just to capture the
> +* We generally don' have to bring up an SMP kernel just to capture the

don't or do not

[toc] | [next] | [standalone]


#1464944

FromDave Young <dyoung@redhat.com>
Date2016-08-18 08:50 +0200
Message-ID<s7pjj-4o3-3@gated-at.bofh.it>
In reply to#1464898
On 08/17/16 at 07:36pm, Joe Perches wrote:
> On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote:
> > nr_cpus can help to save memory. So we should remind user of it.
> 
> trivia:
> > diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
> []
> > @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel:
> >  * Boot parameter "1" boots the dump-capture kernel into single-user
> >    mode without networking. If you want networking, use "3".
> >  
> > -* We generally don' have to bring up a SMP kernel just to capture the
> > +* We generally don' have to bring up an SMP kernel just to capture the
> 
> don't or do not
> 

Use do not is better, also need replace 'We' with 'You' to be
consistent with other part.

[toc] | [prev] | [next] | [standalone]


#1464956

From"Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com>
Date2016-08-18 09:20 +0200
Message-ID<s7pMl-4SU-7@gated-at.bofh.it>
In reply to#1464944
On 08/18/2016 02:47 PM, Dave Young wrote:
> On 08/17/16 at 07:36pm, Joe Perches wrote:
>> On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote:
>>> nr_cpus can help to save memory. So we should remind user of it.
>>
>> trivia:
>>> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
>> []
>>> @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel:
>>>   * Boot parameter "1" boots the dump-capture kernel into single-user
>>>     mode without networking. If you want networking, use "3".
>>>
>>> -* We generally don' have to bring up a SMP kernel just to capture the
>>> +* We generally don' have to bring up an SMP kernel just to capture the
>>
>> don't or do not
>>
>
> Use do not is better, also need replace 'We' with 'You' to be
> consistent with other part.
>
>

I think it's better to fix it in another patch,
for it doesn't have much relevance to the patch set.
I'll post it alone later.

-- 
Thanks
Zhou

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web