Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus

From	"Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus
Date	2016-08-18 09:20 +0200
Message-ID	<s7pMl-4SU-7@gated-at.bofh.it> (permalink)
References	<s7lpn-1Lg-5@gated-at.bofh.it> <s7lpn-1Lg-7@gated-at.bofh.it> <s7lpn-1Lg-3@gated-at.bofh.it> <s7pjj-4o3-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/18/2016 02:47 PM, Dave Young wrote:
> On 08/17/16 at 07:36pm, Joe Perches wrote:
>> On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote:
>>> nr_cpus can help to save memory. So we should remind user of it.
>>
>> trivia:
>>> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
>> []
>>> @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel:
>>>   * Boot parameter "1" boots the dump-capture kernel into single-user
>>>     mode without networking. If you want networking, use "3".
>>>
>>> -* We generally don' have to bring up a SMP kernel just to capture the
>>> +* We generally don' have to bring up an SMP kernel just to capture the
>>
>> don't or do not
>>
>
> Use do not is better, also need replace 'We' with 'You' to be
> consistent with other part.
>
>

I think it's better to fix it in another patch,
for it doesn't have much relevance to the patch set.
I'll post it alone later.

-- 
Thanks
Zhou

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus Joe Perches <joe@perches.com> - 2016-08-18 04:40 +0200
  Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus Dave Young <dyoung@redhat.com> - 2016-08-18 08:50 +0200
    Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus "Zhou, Wenjian/周文剑"   <zhouwj-fnst@cn.fujitsu.com> - 2016-08-18 09:20 +0200

csiph-web