Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463045 > unrolled thread

[PATCH 00/22] Remove deprecated create_workqueue instances

Started byBhaktipriya Shridhar <bhaktipriya96@gmail.com>
First post2016-08-15 20:00 +0200
Last post2016-08-19 17:50 +0200
Articles 14 on this page of 34 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 03/22] IB/multicast: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 02/22] IB/mad: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 08/22] iw_cxgb3: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:20 +0200
    [PATCH 11/22] IB/mthca: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 09/22] IB/qib: Remove deprecated  create_singlethread_workqueue "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2016-08-16 19:40 +0200
    [PATCH 06/22] IB/addr: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    [PATCH 10/22] iw_cxgb4: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:20 +0200
    [PATCH 07/22] IB/iwcm: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:30 +0200
    [PATCH 15/22] IB/mlx5/odp: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 15/22] IB/mlx5/odp: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
    [PATCH 19/22] IB/nes: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 16/22] IB/mlx4: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 16/22] IB/mlx4: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
    [PATCH 18/22] IB/mlx4/mcg: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
    [PATCH 12/22] i40iw_main: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 17/22] IB/mlx4/mad: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
    [PATCH 20/22] IB/ipoib: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 13/22] i40iw_cm: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 21/22] IB/ipoib_verbs: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
      Re: [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
    [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
    Re: [PATCH 00/22] Remove deprecated create_workqueue instances Tejun Heo <tj@kernel.org> - 2016-08-16 01:20 +0200
    Re: [PATCH 00/22] Remove deprecated create_workqueue instances Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1466531 — Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 18:00 +0200
SubjectRe: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
Message-ID<s7Un8-7vi-41@gated-at.bofh.it>
In reply to#1463077

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:43:35PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "mcg_wq" queues work items &group->work
> and &group->timeout_work.
> 
> The workqueue "clean_wq" queues work item mcg_clean_task.
> 
> Both have been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

>  drivers/infiniband/hw/mlx4/mcg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c
> index 8f7ad07..7d30be0 100644
> --- a/drivers/infiniband/hw/mlx4/mcg.c
> +++ b/drivers/infiniband/hw/mlx4/mcg.c
> @@ -1045,7 +1045,7 @@ int mlx4_ib_mcg_port_init(struct mlx4_ib_demux_ctx *ctx)
> 
>  	atomic_set(&ctx->tid, 0);
>  	sprintf(name, "mlx4_ib_mcg%d", ctx->port);
> -	ctx->mcg_wq = create_singlethread_workqueue(name);
> +	ctx->mcg_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
>  	if (!ctx->mcg_wq)
>  		return -ENOMEM;
> 
> @@ -1246,7 +1246,7 @@ void clean_vf_mcast(struct mlx4_ib_demux_ctx *ctx, int slave)
> 
>  int mlx4_ib_mcg_init(void)
>  {
> -	clean_wq = create_singlethread_workqueue("mlx4_ib_mcg");
> +	clean_wq = alloc_ordered_workqueue("mlx4_ib_mcg", WQ_MEM_RECLAIM);
>  	if (!clean_wq)
>  		return -ENOMEM;
> 
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1463078 — [PATCH 12/22] i40iw_main: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 12/22] i40iw_main: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-17@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "virtchnl_wq" queues work items i40iw_cqp_generic_worker
and i40iw_cqp_manage_hmc_fcn_worker. It has been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
index 6e90813..798335f 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_main.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
@@ -1613,7 +1613,7 @@ static int i40iw_open(struct i40e_info *ldev, struct i40e_client *client)
 		status = i40iw_hmc_init_pble(&iwdev->sc_dev, iwdev->pble_rsrc);
 		if (status)
 			break;
-		iwdev->virtchnl_wq = create_singlethread_workqueue("iwvch");
+		iwdev->virtchnl_wq = alloc_ordered_workqueue("iwvch", WQ_MEM_RECLAIM);
 		i40iw_register_notifiers();
 		iwdev->init_state = INET_NOTIFIER;
 		status = i40iw_add_mac_ip(iwdev);
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463079 — [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-23@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "wq" queues work item &ctx->work and the workqueue "ud_wq"
queues work item &dm[i]->work.

Both the workqueues have been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/mlx4/mad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index 9c2e53d..35b1260 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -2070,7 +2070,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
 	}

 	snprintf(name, sizeof name, "mlx4_ibt%d", port);
-	ctx->wq = create_singlethread_workqueue(name);
+	ctx->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
 	if (!ctx->wq) {
 		pr_err("Failed to create tunnelling WQ for port %d\n", port);
 		ret = -ENOMEM;
@@ -2078,7 +2078,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
 	}

 	snprintf(name, sizeof name, "mlx4_ibud%d", port);
-	ctx->ud_wq = create_singlethread_workqueue(name);
+	ctx->ud_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
 	if (!ctx->ud_wq) {
 		pr_err("Failed to create up/down WQ for port %d\n", port);
 		ret = -ENOMEM;
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1466528 — Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 18:00 +0200
SubjectRe: [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
Message-ID<s7Un8-7vi-37@gated-at.bofh.it>
In reply to#1463079

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:43:10PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "wq" queues work item &ctx->work and the workqueue "ud_wq"
> queues work item &dm[i]->work.
> 
> Both the workqueues have been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

> ---
>  drivers/infiniband/hw/mlx4/mad.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
> index 9c2e53d..35b1260 100644
> --- a/drivers/infiniband/hw/mlx4/mad.c
> +++ b/drivers/infiniband/hw/mlx4/mad.c
> @@ -2070,7 +2070,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
>  	}
> 
>  	snprintf(name, sizeof name, "mlx4_ibt%d", port);
> -	ctx->wq = create_singlethread_workqueue(name);
> +	ctx->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
>  	if (!ctx->wq) {
>  		pr_err("Failed to create tunnelling WQ for port %d\n", port);
>  		ret = -ENOMEM;
> @@ -2078,7 +2078,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
>  	}
> 
>  	snprintf(name, sizeof name, "mlx4_ibud%d", port);
> -	ctx->ud_wq = create_singlethread_workqueue(name);
> +	ctx->ud_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
>  	if (!ctx->ud_wq) {
>  		pr_err("Failed to create up/down WQ for port %d\n", port);
>  		ret = -ENOMEM;
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1463081 — [PATCH 20/22] IB/ipoib: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 20/22] IB/ipoib: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-31@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() replaces deprecated
create_singlethread_workqueue().

The workqueue "ipoib_workqueue" that is used for all flush operstions
for the device.

WQ_MEM_RECLAIM has not been set since it is not being used on a memory
reclaim path.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 5f58c41..a8043a3 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -2197,7 +2197,8 @@ static int __init ipoib_init_module(void)
 	 * its private workqueue, and we only queue up flush events
 	 * on our global flush workqueue.  This avoids the deadlocks.
 	 */
-	ipoib_workqueue = create_singlethread_workqueue("ipoib_flush");
+	ipoib_workqueue = alloc_ordered_workqueue("ipoib_flush",
+						  WQ_MEM_RECLAIM);
 	if (!ipoib_workqueue) {
 		ret = -ENOMEM;
 		goto err_fs;
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463082 — [PATCH 13/22] i40iw_cm: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 13/22] i40iw_cm: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-27@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "event_wq" is involved in event handling and queues
i40iw_cm_event_handler.

The workqueue "disconn_wq" is involved in closing connection and queues
i40iw_disconnect_worker.

Both workqueues have been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/i40iw/i40iw_cm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
index d2fa725..76082b3 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
@@ -3166,8 +3166,11 @@ void i40iw_setup_cm_core(struct i40iw_device *iwdev)
 	spin_lock_init(&cm_core->ht_lock);
 	spin_lock_init(&cm_core->listen_list_lock);

-	cm_core->event_wq = create_singlethread_workqueue("iwewq");
-	cm_core->disconn_wq = create_singlethread_workqueue("iwdwq");
+	cm_core->event_wq = alloc_ordered_workqueue("iwewq",
+						    WQ_MEM_RECLAIM);
+
+	cm_core->disconn_wq = alloc_ordered_workqueue("iwdwq",
+						      WQ_MEM_RECLAIM);
 }

 /**
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463085 — [PATCH 21/22] IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 21/22] IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-41@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "wq" queues mulitple work items viz &priv->restart_task,
&priv->cm.rx_reap_task, &priv->cm.skb_task, &priv->neigh_reap_task,
&priv->ah_reap_task, &priv->mcast_task and &priv->carrier_on_task.
The work items require strict execution ordering.
Hence, an ordered dedicated workqueue has been used.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_verbs.c b/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
index 1e7cbba..5737652 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
@@ -156,7 +156,7 @@ int ipoib_transport_dev_init(struct net_device *dev, struct ib_device *ca)
 	 * the various IPoIB tasks assume they will never race against
 	 * themselves, so always use a single thread workqueue
 	 */
-	priv->wq = create_singlethread_workqueue("ipoib_wq");
+	priv->wq = alloc_ordered_workqueue("ipoib_wq", WQ_MEM_RECLAIM);
 	if (!priv->wq) {
 		printk(KERN_WARNING "ipoib: failed to allocate device WQ\n");
 		goto out_free_pd;
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463086 — [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-45@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "cache->wq" queues work items &ent->work (maps to
cache_work_func) and &ent->dwork(maps to delayed_cache_work_func).
It has been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/mlx5/mr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index 8cf2ce5..fb0194d 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -614,7 +614,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev)
 	int err;
 	int i;

-	cache->wq = create_singlethread_workqueue("mkey_cache");
+	cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM);
 	if (!cache->wq) {
 		mlx5_ib_warn(dev, "failed to create work queue\n");
 		return -ENOMEM;
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1466505 — Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 17:50 +0200
SubjectRe: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue
Message-ID<s7Uds-7rO-5@gated-at.bofh.it>
In reply to#1463086

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:41:18PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "cache->wq" queues work items &ent->work (maps to
> cache_work_func) and &ent->dwork(maps to delayed_cache_work_func).
> It has been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>

> ---
>  drivers/infiniband/hw/mlx5/mr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 8cf2ce5..fb0194d 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -614,7 +614,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev)
>  	int err;
>  	int i;
> 
> -	cache->wq = create_singlethread_workqueue("mkey_cache");
> +	cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM);
>  	if (!cache->wq) {
>  		mlx5_ib_warn(dev, "failed to create work queue\n");
>  		return -ENOMEM;
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1466517 — Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 17:50 +0200
SubjectRe: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue
Message-ID<s7Udt-7rO-43@gated-at.bofh.it>
In reply to#1463086

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:41:18PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "cache->wq" queues work items &ent->work (maps to
> cache_work_func) and &ent->dwork(maps to delayed_cache_work_func).
> It has been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  drivers/infiniband/hw/mlx5/mr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>

> 
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 8cf2ce5..fb0194d 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -614,7 +614,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev)
>  	int err;
>  	int i;
> 
> -	cache->wq = create_singlethread_workqueue("mkey_cache");
> +	cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM);
>  	if (!cache->wq) {
>  		mlx5_ib_warn(dev, "failed to create work queue\n");
>  		return -ENOMEM;
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1463087 — [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-43@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "wq" queues work item that maps to alias_guid_work.
It has been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/mlx4/alias_GUID.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx4/alias_GUID.c b/drivers/infiniband/hw/mlx4/alias_GUID.c
index c74ef26..5e99390 100644
--- a/drivers/infiniband/hw/mlx4/alias_GUID.c
+++ b/drivers/infiniband/hw/mlx4/alias_GUID.c
@@ -881,7 +881,7 @@ int mlx4_ib_init_alias_guid_service(struct mlx4_ib_dev *dev)

 		snprintf(alias_wq_name, sizeof alias_wq_name, "alias_guid%d", i);
 		dev->sriov.alias_guid.ports_guid[i].wq =
-			create_singlethread_workqueue(alias_wq_name);
+			alloc_ordered_workqueue(alias_wq_name, WQ_MEM_RECLAIM);
 		if (!dev->sriov.alias_guid.ports_guid[i].wq) {
 			ret = -ENOMEM;
 			goto err_thread;
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1466522 — Re: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 18:00 +0200
SubjectRe: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
Message-ID<s7Un7-7vi-19@gated-at.bofh.it>
In reply to#1463087

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:45:06PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "wq" queues work item that maps to alias_guid_work.
> It has been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

> ---
>  drivers/infiniband/hw/mlx4/alias_GUID.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/alias_GUID.c b/drivers/infiniband/hw/mlx4/alias_GUID.c
> index c74ef26..5e99390 100644
> --- a/drivers/infiniband/hw/mlx4/alias_GUID.c
> +++ b/drivers/infiniband/hw/mlx4/alias_GUID.c
> @@ -881,7 +881,7 @@ int mlx4_ib_init_alias_guid_service(struct mlx4_ib_dev *dev)
> 
>  		snprintf(alias_wq_name, sizeof alias_wq_name, "alias_guid%d", i);
>  		dev->sriov.alias_guid.ports_guid[i].wq =
> -			create_singlethread_workqueue(alias_wq_name);
> +			alloc_ordered_workqueue(alias_wq_name, WQ_MEM_RECLAIM);
>  		if (!dev->sriov.alias_guid.ports_guid[i].wq) {
>  			ret = -ENOMEM;
>  			goto err_thread;
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1463265

FromTejun Heo <tj@kernel.org>
Date2016-08-16 01:20 +0200
Message-ID<s6zkJ-3DX-11@gated-at.bofh.it>
In reply to#1463045
Hello,

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.

Patches generally look good to me.  The only thing is that there seem
to be several patches where ordering doesn't seem necessary, at least
judging from the patch descriptions.  It'd be great to clarify those.

Thanks.

-- 
tejun

[toc] | [prev] | [next] | [standalone]

#1466507

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 17:50 +0200
Message-ID<s7Uds-7rO-7@gated-at.bofh.it>
In reply to#1463045

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
> 
> Bhaktipriya Shridhar (22):
>   IB/sa : Remove deprecated create_singlethread_workqueue
>   IB/mad: Remove deprecated create_singlethread_workqueue
>   IB/multicast: Remove deprecated create_singlethread_workqueue
>   IB/ucma: Remove deprecated create_singlethread_workqueue
>   IB/cma: Remove deprecated create_singlethread_workqueue
>   IB/addr: Remove deprecated create_singlethread_workqueue
>   IB/iwcm: Remove deprecated create_singlethread_workqueue
>   iw_cxgb3: Remove deprecated create_singlethread_workqueue
>   IB/qib: Remove deprecated create_singlethread_workqueue
>   iw_cxgb4: Remove deprecated create_singlethread_workqueue
>   IB/mthca: Remove deprecated create_singlethread_workqueue
>   i40iw_main: Remove deprecated create_singlethread_workqueue
>   i40iw_cm: Remove deprecated create_singlethread_workqueue
>   IB/mlx5: Remove deprecated create_singlethread_workqueue
>   IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
>   IB/mlx4: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
>   IB/nes: Remove deprecated create_singlethread_workqueue
>   IB/ipoib: Remove deprecated create_singlethread_workqueue
>   IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

Thank you for doing it in one patch set, it is much easier to review.

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web