Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466528

Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Aug 15, 2016 at 11:43:10PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "wq" queues work item &ctx->work and the workqueue "ud_wq"
> queues work item &dm[i]->work.
> 
> Both the workqueues have been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

> ---
>  drivers/infiniband/hw/mlx4/mad.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
> index 9c2e53d..35b1260 100644
> --- a/drivers/infiniband/hw/mlx4/mad.c
> +++ b/drivers/infiniband/hw/mlx4/mad.c
> @@ -2070,7 +2070,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
>  	}
> 
>  	snprintf(name, sizeof name, "mlx4_ibt%d", port);
> -	ctx->wq = create_singlethread_workqueue(name);
> +	ctx->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
>  	if (!ctx->wq) {
>  		pr_err("Failed to create tunnelling WQ for port %d\n", port);
>  		ret = -ENOMEM;
> @@ -2078,7 +2078,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
>  	}
> 
>  	snprintf(name, sizeof name, "mlx4_ibud%d", port);
> -	ctx->ud_wq = create_singlethread_workqueue(name);
> +	ctx->ud_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
>  	if (!ctx->ud_wq) {
>  		pr_err("Failed to create up/down WQ for port %d\n", port);
>  		ret = -ENOMEM;
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
  [PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
  [PATCH 03/22] IB/multicast: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
  [PATCH 02/22] IB/mad: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
  [PATCH 08/22] iw_cxgb3: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    RE: [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:20 +0200
  [PATCH 11/22] IB/mthca: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
  [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    RE: [PATCH 09/22] IB/qib: Remove deprecated  create_singlethread_workqueue "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2016-08-16 19:40 +0200
  [PATCH 06/22] IB/addr: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
  [PATCH 10/22] iw_cxgb4: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    RE: [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:20 +0200
  [PATCH 07/22] IB/iwcm: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    RE: [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:30 +0200
  [PATCH 15/22] IB/mlx5/odp: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    Re: [PATCH 15/22] IB/mlx5/odp: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
  [PATCH 19/22] IB/nes: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
  [PATCH 16/22] IB/mlx4: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    Re: [PATCH 16/22] IB/mlx4: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
  [PATCH 18/22] IB/mlx4/mcg: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
  [PATCH 12/22] i40iw_main: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
  [PATCH 17/22] IB/mlx4/mad: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
  [PATCH 20/22] IB/ipoib: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
  [PATCH 13/22] i40iw_cm: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
  [PATCH 21/22] IB/ipoib_verbs: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
  [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    Re: [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
    Re: [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
  [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    Re: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
  Re: [PATCH 00/22] Remove deprecated create_workqueue instances Tejun Heo <tj@kernel.org> - 2016-08-16 01:20 +0200
  Re: [PATCH 00/22] Remove deprecated create_workqueue instances Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200

csiph-web