Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1463849 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-08-16 16:30 +0200 |
| Last post | 2016-08-17 19:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-16 16:30 +0200
Re: [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc Sakari Ailus <sakari.ailus@iki.fi> - 2016-08-17 11:10 +0200
Re: [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-17 19:30 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-08-16 16:30 +0200 |
| Subject | [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc |
| Message-ID | <s6Nxo-4cZ-15@gated-at.bofh.it> |
The kernel-doc has the wrong function name and also the pindex parameter is missing in the documentation. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- This patch was posted some weeks ago but I noticed that wasn't picked by patchwork, so I'm resend it. drivers/media/v4l2-core/videobuf2-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index ca8ffeb56d72..1dbd7beb71f0 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -1726,8 +1726,9 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) } /** - * vb2_dqbuf() - Dequeue a buffer to the userspace + * vb2_core_dqbuf() - Dequeue a buffer to the userspace * @q: videobuf2 queue + * @pindex: id number of the buffer * @pb: buffer structure passed from userspace to vidioc_dqbuf handler * in driver * @nonblocking: if true, this call will not sleep waiting for a buffer if no -- 2.5.5
[toc] | [next] | [standalone]
| From | Sakari Ailus <sakari.ailus@iki.fi> |
|---|---|
| Date | 2016-08-17 11:10 +0200 |
| Message-ID | <s751f-7ok-9@gated-at.bofh.it> |
| In reply to | #1463849 |
Hi Javier, On Tue, Aug 16, 2016 at 10:20:16AM -0400, Javier Martinez Canillas wrote: > The kernel-doc has the wrong function name and also the pindex > parameter is missing in the documentation. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > This patch was posted some weeks ago but I noticed that wasn't > picked by patchwork, so I'm resend it. > > drivers/media/v4l2-core/videobuf2-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c > index ca8ffeb56d72..1dbd7beb71f0 100644 > --- a/drivers/media/v4l2-core/videobuf2-core.c > +++ b/drivers/media/v4l2-core/videobuf2-core.c > @@ -1726,8 +1726,9 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) > } > > /** > - * vb2_dqbuf() - Dequeue a buffer to the userspace > + * vb2_core_dqbuf() - Dequeue a buffer to the userspace > * @q: videobuf2 queue > + * @pindex: id number of the buffer How about: "Pointer to the buffer index. May be NULL.". Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > * @pb: buffer structure passed from userspace to vidioc_dqbuf handler > * in driver > * @nonblocking: if true, this call will not sleep waiting for a buffer if no -- Cheers, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
[toc] | [prev] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-08-17 19:30 +0200 |
| Message-ID | <s7cP7-469-19@gated-at.bofh.it> |
| In reply to | #1464428 |
Hello Sakari, On 08/17/2016 05:01 AM, Sakari Ailus wrote: > Hi Javier, > > On Tue, Aug 16, 2016 at 10:20:16AM -0400, Javier Martinez Canillas wrote: >> The kernel-doc has the wrong function name and also the pindex >> parameter is missing in the documentation. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> --- >> >> This patch was posted some weeks ago but I noticed that wasn't >> picked by patchwork, so I'm resend it. >> >> drivers/media/v4l2-core/videobuf2-core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c >> index ca8ffeb56d72..1dbd7beb71f0 100644 >> --- a/drivers/media/v4l2-core/videobuf2-core.c >> +++ b/drivers/media/v4l2-core/videobuf2-core.c >> @@ -1726,8 +1726,9 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) >> } >> >> /** >> - * vb2_dqbuf() - Dequeue a buffer to the userspace >> + * vb2_core_dqbuf() - Dequeue a buffer to the userspace >> * @q: videobuf2 queue >> + * @pindex: id number of the buffer > > How about: "Pointer to the buffer index. May be NULL.". > Sure, I'll change it. > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > Thanks. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web