Re: [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc
Date	2016-08-17 19:30 +0200
Message-ID	<s7cP7-469-19@gated-at.bofh.it> (permalink)
References	<s6Nxo-4cZ-15@gated-at.bofh.it> <s751f-7ok-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Sakari,

On 08/17/2016 05:01 AM, Sakari Ailus wrote:
> Hi Javier,
> 
> On Tue, Aug 16, 2016 at 10:20:16AM -0400, Javier Martinez Canillas wrote:
>> The kernel-doc has the wrong function name and also the pindex
>> parameter is missing in the documentation.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> This patch was posted some weeks ago but I noticed that wasn't
>> picked by patchwork, so I'm resend it.
>>
>>  drivers/media/v4l2-core/videobuf2-core.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
>> index ca8ffeb56d72..1dbd7beb71f0 100644
>> --- a/drivers/media/v4l2-core/videobuf2-core.c
>> +++ b/drivers/media/v4l2-core/videobuf2-core.c
>> @@ -1726,8 +1726,9 @@ static void __vb2_dqbuf(struct vb2_buffer *vb)
>>  }
>>  
>>  /**
>> - * vb2_dqbuf() - Dequeue a buffer to the userspace
>> + * vb2_core_dqbuf() - Dequeue a buffer to the userspace
>>   * @q:		videobuf2 queue
>> + * @pindex:	id number of the buffer
> 
> How about: "Pointer to the buffer index. May be NULL.".
>

Sure, I'll change it.
 
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>

Thanks.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-16 16:30 +0200
  Re: [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc Sakari Ailus <sakari.ailus@iki.fi> - 2016-08-17 11:10 +0200
    Re: [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-17 19:30 +0200

csiph-web