Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1460982 > unrolled thread
| Started by | Baoquan He <bhe@redhat.com> |
|---|---|
| First post | 2016-08-12 09:40 +0200 |
| Last post | 2016-08-15 12:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[Patch v2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Baoquan He <bhe@redhat.com> - 2016-08-12 09:40 +0200
[tip:x86/apic] x86/apic, ACPI: Fix incorrect assignment when handling apic/x2apic entries tip-bot for Baoquan He <tipbot@zytor.com> - 2016-08-15 12:20 +0200
| From | Baoquan He <bhe@redhat.com> |
|---|---|
| Date | 2016-08-12 09:40 +0200 |
| Subject | [Patch v2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries |
| Message-ID | <s5fep-793-11@gated-at.bofh.it> |
By pure accident the bug makes no functional difference, because the only
expression where we are using these values is (!count && !x2count), in which
the variables are interchangeable, but it makes sense to fix the bug
nevertheless.
Signed-off-by: Baoquan He <bhe@redhat.com>
[Ingo rewrote changelog]
---
v1-v2:
-Just update change log.
arch/x86/kernel/acpi/boot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 90d84c3..2b25d3f 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void)
return ret;
}
- x2count = madt_proc[0].count;
- count = madt_proc[1].count;
+ count = madt_proc[0].count;
+ x2count = madt_proc[1].count;
}
if (!count && !x2count) {
printk(KERN_ERR PREFIX "No LAPIC entries present\n");
--
2.5.5
[toc] | [next] | [standalone]
| From | tip-bot for Baoquan He <tipbot@zytor.com> |
|---|---|
| Date | 2016-08-15 12:20 +0200 |
| Subject | [tip:x86/apic] x86/apic, ACPI: Fix incorrect assignment when handling apic/x2apic entries |
| Message-ID | <s6n9T-4ig-7@gated-at.bofh.it> |
| In reply to | #1460982 |
Commit-ID: 31b02dd718712f4c45afbeea7fbd187ecb1b202c
Gitweb: http://git.kernel.org/tip/31b02dd718712f4c45afbeea7fbd187ecb1b202c
Author: Baoquan He <bhe@redhat.com>
AuthorDate: Fri, 12 Aug 2016 15:21:47 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 15 Aug 2016 08:53:44 +0200
x86/apic, ACPI: Fix incorrect assignment when handling apic/x2apic entries
By pure accident the bug makes no functional difference, because the only
expression where we are using these values is (!count && !x2count), in which
the variables are interchangeable, but it makes sense to fix the bug
nevertheless.
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-acpi@vger.kernel.org
Cc: rjw@rjwysocki.net
Link: http://lkml.kernel.org/r/1470986507-24191-1-git-send-email-bhe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/acpi/boot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 2087bea..1ad5fe2 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1018,8 +1018,8 @@ static int __init acpi_parse_madt_lapic_entries(void)
return ret;
}
- x2count = madt_proc[0].count;
- count = madt_proc[1].count;
+ count = madt_proc[0].count;
+ x2count = madt_proc[1].count;
}
if (!count && !x2count) {
printk(KERN_ERR PREFIX "No LAPIC entries present\n");
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web