Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460982

[Patch v2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries

Show all headers | View raw

By pure accident the bug makes no functional difference, because the only
expression where we are using these values is (!count && !x2count), in which
the variables are interchangeable, but it makes sense to fix the bug
nevertheless.

Signed-off-by: Baoquan He <bhe@redhat.com>
[Ingo rewrote changelog]
---
v1-v2:
  -Just update change log.

 arch/x86/kernel/acpi/boot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 90d84c3..2b25d3f 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void)
 			return ret;
 		}
 
-		x2count = madt_proc[0].count;
-		count = madt_proc[1].count;
+		count = madt_proc[0].count;
+		x2count = madt_proc[1].count;
 	}
 	if (!count && !x2count) {
 		printk(KERN_ERR PREFIX "No LAPIC entries present\n");
-- 
2.5.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[Patch v2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Baoquan He <bhe@redhat.com> - 2016-08-12 09:40 +0200
  [tip:x86/apic] x86/apic, ACPI: Fix incorrect assignment when  handling apic/x2apic entries tip-bot for Baoquan He <tipbot@zytor.com> - 2016-08-15 12:20 +0200

csiph-web