Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1461736 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2016-08-14 11:10 +0200 |
| Last post | 2016-08-23 23:10 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-14 11:10 +0200
Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-08-15 11:00 +0200
Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-16 01:00 +0200
Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-23 23:10 +0200
Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-23 23:10 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-08-14 11:10 +0200 |
| Subject | [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue |
| Message-ID | <s5ZAC-5TR-15@gated-at.bofh.it> |
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion. The workqueue "ts_workq" has been identity converted.
It queues work items viz &wm->ts_reader and &wm->pen_event_work which map
to wm97xx_pen_irq_worker (handles a pen down interrupt) and
wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence,
an ordered dedicated workqueue has been used.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/input/touchscreen/wm97xx-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
index 1534e9b..c0af844 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -500,7 +500,7 @@ static int wm97xx_ts_input_open(struct input_dev *idev)
{
struct wm97xx *wm = input_get_drvdata(idev);
- wm->ts_workq = create_singlethread_workqueue("kwm97xx");
+ wm->ts_workq = alloc_ordered_workqueue("kwm97xx", WQ_MEM_RECLAIM);
if (wm->ts_workq == NULL) {
dev_err(wm->dev,
"Failed to create workqueue\n");
--
2.1.4
[toc] | [next] | [standalone]
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2016-08-15 11:00 +0200 |
| Message-ID | <s6lUu-3kK-39@gated-at.bofh.it> |
| In reply to | #1461736 |
On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. The workqueue "ts_workq" has been identity converted. > > It queues work items viz &wm->ts_reader and &wm->pen_event_work which map > to wm97xx_pen_irq_worker (handles a pen down interrupt) and > wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence, > an ordered dedicated workqueue has been used. > > WQ_MEM_RECLAIM has been set to ensure forward progress under memory > pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
[toc] | [prev] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2016-08-16 01:00 +0200 |
| Message-ID | <s6z1o-3il-25@gated-at.bofh.it> |
| In reply to | #1461736 |
On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. The workqueue "ts_workq" has been identity converted. > > It queues work items viz &wm->ts_reader and &wm->pen_event_work which map > to wm97xx_pen_irq_worker (handles a pen down interrupt) and > wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence, > an ordered dedicated workqueue has been used. > > WQ_MEM_RECLAIM has been set to ensure forward progress under memory > pressure. I'm not sure WQ_MEM_RECLAIM makes sense on an input driver. Thanks. -- tejun
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-08-23 23:10 +0200 |
| Message-ID | <s9r7j-ZT-13@gated-at.bofh.it> |
| In reply to | #1461736 |
On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion. The workqueue "ts_workq" has been identity converted.
>
> It queues work items viz &wm->ts_reader and &wm->pen_event_work which map
> to wm97xx_pen_irq_worker (handles a pen down interrupt) and
> wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence,
> an ordered dedicated workqueue has been used.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/wm97xx-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
> index 1534e9b..c0af844 100644
> --- a/drivers/input/touchscreen/wm97xx-core.c
> +++ b/drivers/input/touchscreen/wm97xx-core.c
> @@ -500,7 +500,7 @@ static int wm97xx_ts_input_open(struct input_dev *idev)
> {
> struct wm97xx *wm = input_get_drvdata(idev);
>
> - wm->ts_workq = create_singlethread_workqueue("kwm97xx");
> + wm->ts_workq = alloc_ordered_workqueue("kwm97xx", WQ_MEM_RECLAIM);
> if (wm->ts_workq == NULL) {
> dev_err(wm->dev,
> "Failed to create workqueue\n");
> --
> 2.1.4
>
--
Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-08-23 23:10 +0200 |
| Message-ID | <s9r7j-ZT-15@gated-at.bofh.it> |
| In reply to | #1468859 |
On Tue, Aug 23, 2016 at 02:01:33PM -0700, Dmitry Torokhov wrote:
> On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote:
> > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> > deprecated create_singlethread_workqueue(). This is the identity
> > conversion. The workqueue "ts_workq" has been identity converted.
> >
> > It queues work items viz &wm->ts_reader and &wm->pen_event_work which map
> > to wm97xx_pen_irq_worker (handles a pen down interrupt) and
> > wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence,
> > an ordered dedicated workqueue has been used.
> >
> > WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> > pressure.
> >
> > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
>
> Applied, thank you.
(Sans WQ_MEM_RECLAIM).
>
> > ---
> > drivers/input/touchscreen/wm97xx-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
> > index 1534e9b..c0af844 100644
> > --- a/drivers/input/touchscreen/wm97xx-core.c
> > +++ b/drivers/input/touchscreen/wm97xx-core.c
> > @@ -500,7 +500,7 @@ static int wm97xx_ts_input_open(struct input_dev *idev)
> > {
> > struct wm97xx *wm = input_get_drvdata(idev);
> >
> > - wm->ts_workq = create_singlethread_workqueue("kwm97xx");
> > + wm->ts_workq = alloc_ordered_workqueue("kwm97xx", WQ_MEM_RECLAIM);
> > if (wm->ts_workq == NULL) {
> > dev_err(wm->dev,
> > "Failed to create workqueue\n");
> > --
> > 2.1.4
> >
>
> --
> Dmitry
--
Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web