Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463249

Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue
Date 2016-08-16 01:00 +0200
Message-ID <s6z1o-3il-25@gated-at.bofh.it> (permalink)
References <s5ZAC-5TR-17@gated-at.bofh.it> <s5ZAC-5TR-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion. The workqueue "ts_workq" has been identity converted.
> 
> It queues work items viz &wm->ts_reader and &wm->pen_event_work which map
> to wm97xx_pen_irq_worker (handles a pen down interrupt) and
> wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence,
> an ordered dedicated workqueue has been used.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.

I'm not sure WQ_MEM_RECLAIM makes sense on an input driver.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] Input: wm97xx: Remove deprecated  create_singletheread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-14 11:10 +0200
  Re: [PATCH 3/3] Input: wm97xx: Remove deprecated  create_singletheread_workqueue Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-08-15 11:00 +0200
  Re: [PATCH 3/3] Input: wm97xx: Remove deprecated  create_singletheread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-16 01:00 +0200
  Re: [PATCH 3/3] Input: wm97xx: Remove deprecated  create_singletheread_workqueue Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-23 23:10 +0200
    Re: [PATCH 3/3] Input: wm97xx: Remove deprecated  create_singletheread_workqueue Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-23 23:10 +0200

csiph-web