Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1460721 > unrolled thread
| Started by | Steve Muckle <steve.muckle@linaro.org> |
|---|---|
| First post | 2016-08-11 20:10 +0200 |
| Last post | 2016-08-11 20:10 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [Update][PATCH 1/2] cpufreq / sched: Pass flags to cpufreq_update_util() Steve Muckle <steve.muckle@linaro.org> - 2016-08-11 20:10 +0200
Re: [Update][PATCH 1/2] cpufreq / sched: Pass flags to cpufreq_update_util() Steve Muckle <steve.muckle@linaro.org> - 2016-08-11 20:10 +0200
| From | Steve Muckle <steve.muckle@linaro.org> |
|---|---|
| Date | 2016-08-11 20:10 +0200 |
| Subject | Re: [Update][PATCH 1/2] cpufreq / sched: Pass flags to cpufreq_update_util() |
| Message-ID | <s52Ay-7iZ-3@gated-at.bofh.it> |
On Wed, Aug 10, 2016 at 03:49:07AM +0200, Rafael J. Wysocki wrote:
> Index: linux-pm/kernel/sched/fair.c
> ===================================================================
> --- linux-pm.orig/kernel/sched/fair.c
> +++ linux-pm/kernel/sched/fair.c
> @@ -2875,11 +2875,8 @@ static inline void update_tg_load_avg(st
>
> static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
> {
> - struct rq *rq = rq_of(cfs_rq);
> - int cpu = cpu_of(rq);
> -
> - if (cpu == smp_processor_id() && &rq->cfs == cfs_rq) {
> - unsigned long max = rq->cpu_capacity_orig;
> + if (&this_rq()->cfs == cfs_rq) {
> + struct rq *rq = rq_of(cfs_rq);
>
> /*
> * There are a few boundary cases this might miss but it should
> @@ -2897,8 +2894,8 @@ static inline void cfs_rq_util_change(st
> *
> * See cpu_util().
> */
> - cpufreq_update_util(rq_clock(rq),
> - min(cfs_rq->avg.util_avg, max), max);
> + if (cpu_of(rq) == smp_processor_id())
Isn't this test against smp_processor_id() redundant since
this_rq()->cfs == cfs_rq?
> + cpufreq_update_util(rq_clock(rq), 0);
All else looked good to me.
thanks,
Steve
[toc] | [next] | [standalone]
| From | Steve Muckle <steve.muckle@linaro.org> |
|---|---|
| Date | 2016-08-11 20:10 +0200 |
| Message-ID | <s52Ay-7iZ-11@gated-at.bofh.it> |
| In reply to | #1460721 |
On Thu, Aug 11, 2016 at 11:03:47AM -0700, Steve Muckle wrote:
> On Wed, Aug 10, 2016 at 03:49:07AM +0200, Rafael J. Wysocki wrote:
> > Index: linux-pm/kernel/sched/fair.c
> > ===================================================================
> > --- linux-pm.orig/kernel/sched/fair.c
> > +++ linux-pm/kernel/sched/fair.c
> > @@ -2875,11 +2875,8 @@ static inline void update_tg_load_avg(st
> >
> > static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
> > {
> > - struct rq *rq = rq_of(cfs_rq);
> > - int cpu = cpu_of(rq);
> > -
> > - if (cpu == smp_processor_id() && &rq->cfs == cfs_rq) {
> > - unsigned long max = rq->cpu_capacity_orig;
> > + if (&this_rq()->cfs == cfs_rq) {
> > + struct rq *rq = rq_of(cfs_rq);
> >
> > /*
> > * There are a few boundary cases this might miss but it should
> > @@ -2897,8 +2894,8 @@ static inline void cfs_rq_util_change(st
> > *
> > * See cpu_util().
> > */
> > - cpufreq_update_util(rq_clock(rq),
> > - min(cfs_rq->avg.util_avg, max), max);
> > + if (cpu_of(rq) == smp_processor_id())
>
> Isn't this test against smp_processor_id() redundant since
> this_rq()->cfs == cfs_rq?
Sorry, I see this is modified in the next patch.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web