Re: [Update][PATCH 1/2] cpufreq / sched: Pass flags to cpufreq_update_util()

From	Steve Muckle <steve.muckle@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [Update][PATCH 1/2] cpufreq / sched: Pass flags to cpufreq_update_util()
Date	2016-08-11 20:10 +0200
Message-ID	<s52Ay-7iZ-3@gated-at.bofh.it> (permalink)
References	<s4qbT-6NI-9@gated-at.bofh.it> <s4qbT-6NI-13@gated-at.bofh.it> <s4qOB-71t-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 10, 2016 at 03:49:07AM +0200, Rafael J. Wysocki wrote:
> Index: linux-pm/kernel/sched/fair.c
> ===================================================================
> --- linux-pm.orig/kernel/sched/fair.c
> +++ linux-pm/kernel/sched/fair.c
> @@ -2875,11 +2875,8 @@ static inline void update_tg_load_avg(st
>  
>  static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
>  {
> -	struct rq *rq = rq_of(cfs_rq);
> -	int cpu = cpu_of(rq);
> -
> -	if (cpu == smp_processor_id() && &rq->cfs == cfs_rq) {
> -		unsigned long max = rq->cpu_capacity_orig;
> +	if (&this_rq()->cfs == cfs_rq) {
> +		struct rq *rq = rq_of(cfs_rq);
>  
>  		/*
>  		 * There are a few boundary cases this might miss but it should
> @@ -2897,8 +2894,8 @@ static inline void cfs_rq_util_change(st
>  		 *
>  		 * See cpu_util().
>  		 */
> -		cpufreq_update_util(rq_clock(rq),
> -				    min(cfs_rq->avg.util_avg, max), max);
> +		if (cpu_of(rq) == smp_processor_id())

Isn't this test against smp_processor_id() redundant since
this_rq()->cfs == cfs_rq?

> +			cpufreq_update_util(rq_clock(rq), 0);

All else looked good to me.

thanks,
Steve

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [Update][PATCH 1/2] cpufreq / sched: Pass flags to  cpufreq_update_util() Steve Muckle <steve.muckle@linaro.org> - 2016-08-11 20:10 +0200
  Re: [Update][PATCH 1/2] cpufreq / sched: Pass flags to  cpufreq_update_util() Steve Muckle <steve.muckle@linaro.org> - 2016-08-11 20:10 +0200

csiph-web