Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1459172 > unrolled thread

[PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking

Started byLidza Louina <lidza.louina@oracle.com>
First post2016-08-10 01:20 +0200
Last post2016-08-10 01:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking Lidza Louina <lidza.louina@oracle.com> - 2016-08-10 01:20 +0200

#1459172 — [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking

FromLidza Louina <lidza.louina@oracle.com>
Date2016-08-10 01:20 +0200
Subject[PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking
Message-ID<s4otr-5AY-9@gated-at.bofh.it>
The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
The code had an up() where a down() should've been. This patch fixes that.

Signed-off-by: Lidza Louina <Lidza.Louina@oracle.com>
---
 drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 7748523..16f0b19 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
 	allow_signal(SIGTERM);
 
 	pcmdpriv->cmdthd_running = true;
-	up(&pcmdpriv->terminate_cmdthread_sema);
+	down(&pcmdpriv->terminate_cmdthread_sema);
 
 	RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
 
-- 
2.7.4

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web