[PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking

From	Lidza Louina <lidza.louina@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking
Date	2016-08-10 01:20 +0200
Message-ID	<s4otr-5AY-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
The code had an up() where a down() should've been. This patch fixes that.

Signed-off-by: Lidza Louina <Lidza.Louina@oracle.com>
---
 drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 7748523..16f0b19 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
 	allow_signal(SIGTERM);
 
 	pcmdpriv->cmdthd_running = true;
-	up(&pcmdpriv->terminate_cmdthread_sema);
+	down(&pcmdpriv->terminate_cmdthread_sema);
 
 	RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
 
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking Lidza Louina <lidza.louina@oracle.com> - 2016-08-10 01:20 +0200

csiph-web