Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459100 > unrolled thread

Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode  page copy Tejun Heo <tj@kernel.org> - 2016-08-09 22:20 +0200

#1459100 — Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

On Sat, Jul 23, 2016 at 02:34:08AM +0800, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
> 
> ata_mselect_*() would initialize a char array for storing a copy of
> the current mode page. However, char could be signed char. In that
> case, bytes larger than 127 would be converted to negative number.
> 
> For example, 0xff from def_control_mpage[] would become -1. This
> prevented ata_mselect_control() from working at all, since when it
> did the read-only bits check, there would always be a mismatch.
> 
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>

Applied to libata/for-4.9.

Thanks.

-- 
tejun

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web