Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy
Date	2016-08-09 22:20 +0200
Message-ID	<s4lFg-3PL-31@gated-at.bofh.it> (permalink)
References	<rXNmW-WX-15@gated-at.bofh.it> <rXNwB-117-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 23, 2016 at 02:34:08AM +0800, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
> 
> ata_mselect_*() would initialize a char array for storing a copy of
> the current mode page. However, char could be signed char. In that
> case, bytes larger than 127 would be converted to negative number.
> 
> For example, 0xff from def_control_mpage[] would become -1. This
> prevented ata_mselect_control() from working at all, since when it
> did the read-only bits check, there would always be a mismatch.
> 
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>

Applied to libata/for-4.9.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode  page copy Tejun Heo <tj@kernel.org> - 2016-08-09 22:20 +0200

csiph-web