Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1459843 > unrolled thread
| Started by | <patrice.chotard@st.com> |
|---|---|
| First post | 2016-08-10 22:30 +0200 |
| Last post | 2016-08-11 13:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] STi: Add ports-implemented property support <patrice.chotard@st.com> - 2016-08-10 22:30 +0200
[PATCH 1/2] ahci: st: Add ports-implemented property in support <patrice.chotard@st.com> - 2016-08-10 23:00 +0200
Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-11 13:10 +0200
| From | <patrice.chotard@st.com> |
|---|---|
| Date | 2016-08-10 22:30 +0200 |
| Subject | [PATCH 0/2] STi: Add ports-implemented property support |
| Message-ID | <s4GgH-79-57@gated-at.bofh.it> |
From: Patrice Chotard <patrice.chotard@st.com> Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL returns 0. So force HOST_PORTS_IMPL to 1 by using ports-implemented DT property. Update achci_st driver and STi dts accordingly Patrice Chotard (2): ahci: st: Add ports-implemented property in support ARM: dts: STiH407-family: Add ports-implemented property in sata nodes arch/arm/boot/dts/stih407-family.dtsi | 4 ++++ drivers/ata/ahci_st.c | 4 ++++ 2 files changed, 8 insertions(+) -- 1.9.1
[toc] | [next] | [standalone]
| From | <patrice.chotard@st.com> |
|---|---|
| Date | 2016-08-10 23:00 +0200 |
| Subject | [PATCH 1/2] ahci: st: Add ports-implemented property in support |
| Message-ID | <s4ILv-1Hq-21@gated-at.bofh.it> |
| In reply to | #1459843 |
From: Patrice Chotard <patrice.chotard@st.com>
Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
returns 0. So force_port_map to 1 by using ports-implemented
DT property.
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
drivers/ata/ahci_st.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
index 8ff428f..bc345f2 100644
--- a/drivers/ata/ahci_st.c
+++ b/drivers/ata/ahci_st.c
@@ -147,6 +147,7 @@ static struct scsi_host_template ahci_platform_sht = {
static int st_ahci_probe(struct platform_device *pdev)
{
+ struct device *dev = &pdev->dev;
struct st_ahci_drv_data *drv_data;
struct ahci_host_priv *hpriv;
int err;
@@ -170,6 +171,9 @@ static int st_ahci_probe(struct platform_device *pdev)
st_ahci_configure_oob(hpriv->mmio);
+ of_property_read_u32(dev->of_node,
+ "ports-implemented", &hpriv->force_port_map);
+
err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info,
&ahci_platform_sht);
if (err) {
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-08-11 13:10 +0200 |
| Subject | Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support |
| Message-ID | <s4W26-31e-7@gated-at.bofh.it> |
| In reply to | #1459922 |
On 8/10/2016 6:37 PM, patrice.chotard@st.com wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
> returns 0. So force_port_map to 1 by using ports-implemented
> DT property.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
> drivers/ata/ahci_st.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
> index 8ff428f..bc345f2 100644
> --- a/drivers/ata/ahci_st.c
> +++ b/drivers/ata/ahci_st.c
> @@ -147,6 +147,7 @@ static struct scsi_host_template ahci_platform_sht = {
>
> static int st_ahci_probe(struct platform_device *pdev)
> {
> + struct device *dev = &pdev->dev;
Why? You could just use 'pdev'.
> struct st_ahci_drv_data *drv_data;
> struct ahci_host_priv *hpriv;
> int err;
> @@ -170,6 +171,9 @@ static int st_ahci_probe(struct platform_device *pdev)
>
> st_ahci_configure_oob(hpriv->mmio);
>
> + of_property_read_u32(dev->of_node,
pdev->dev.of_node
> + "ports-implemented", &hpriv->force_port_map);
> +
> err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info,
> &ahci_platform_sht);
> if (err) {
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web