Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1460404

Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support

From Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support
Date 2016-08-11 13:10 +0200
Message-ID <s4W26-31e-7@gated-at.bofh.it> (permalink)
References <s4GgH-79-57@gated-at.bofh.it> <s4ILv-1Hq-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 8/10/2016 6:37 PM, patrice.chotard@st.com wrote:

> From: Patrice Chotard <patrice.chotard@st.com>
>
> Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
> returns 0. So force_port_map to 1 by using ports-implemented
> DT property.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>  drivers/ata/ahci_st.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
> index 8ff428f..bc345f2 100644
> --- a/drivers/ata/ahci_st.c
> +++ b/drivers/ata/ahci_st.c
> @@ -147,6 +147,7 @@ static struct scsi_host_template ahci_platform_sht = {
>
>  static int st_ahci_probe(struct platform_device *pdev)
>  {
> +	struct device *dev = &pdev->dev;

    Why? You could just use 'pdev'.

>  	struct st_ahci_drv_data *drv_data;
>  	struct ahci_host_priv *hpriv;
>  	int err;
> @@ -170,6 +171,9 @@ static int st_ahci_probe(struct platform_device *pdev)
>
>  	st_ahci_configure_oob(hpriv->mmio);
>
> +	of_property_read_u32(dev->of_node,

    pdev->dev.of_node

> +			     "ports-implemented", &hpriv->force_port_map);
> +
>  	err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info,
>  				      &ahci_platform_sht);
>  	if (err) {

MBR, Sergei

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] STi: Add ports-implemented property support <patrice.chotard@st.com> - 2016-08-10 22:30 +0200
  [PATCH 1/2] ahci: st: Add ports-implemented property in support <patrice.chotard@st.com> - 2016-08-10 23:00 +0200
    Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-11 13:10 +0200

csiph-web