Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1459156 > unrolled thread
| Started by | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| First post | 2016-08-10 00:10 +0200 |
| Last post | 2016-08-11 16:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/4] befs: dump inode_size superblock information Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-10 00:10 +0200
Re: [PATCH 1/4] befs: dump inode_size superblock information Salah Triki <salah.triki@gmail.com> - 2016-08-10 23:50 +0200
Re: [PATCH 1/4] befs: dump inode_size superblock information Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-11 12:10 +0200
Re: [PATCH 1/4] befs: dump inode_size superblock information Salah Triki <salah.triki@gmail.com> - 2016-08-11 16:10 +0200
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Date | 2016-08-10 00:10 +0200 |
| Subject | [PATCH 1/4] befs: dump inode_size superblock information |
| Message-ID | <s4nnH-4Yg-9@gated-at.bofh.it> |
befs_dump_super_block() wasn't giving the inode_size information when dumping all elements of the superblock. Add this element to have complete information of the superblock. Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> --- Hi, This is a series of superblock information related changes. Thanks, Luis fs/befs/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/befs/debug.c b/fs/befs/debug.c index 4de7cff..85c1339 100644 --- a/fs/befs/debug.c +++ b/fs/befs/debug.c @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup) befs_debug(sb, " num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks)); befs_debug(sb, " used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks)); + befs_debug(sb, " inode_size %u", fs32_to_cpu(sb, sup->inode_size)); befs_debug(sb, " magic2 %08x", fs32_to_cpu(sb, sup->magic2)); befs_debug(sb, " blocks_per_ag %u", -- 2.5.1
[toc] | [next] | [standalone]
| From | Salah Triki <salah.triki@gmail.com> |
|---|---|
| Date | 2016-08-10 23:50 +0200 |
| Message-ID | <s4JxT-2gM-1@gated-at.bofh.it> |
| In reply to | #1459156 |
On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote: > befs_dump_super_block() wasn't giving the inode_size information when > dumping all elements of the superblock. Add this element to have complete > information of the superblock. > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > > Hi, > > This is a series of superblock information related changes. > > Thanks, > Luis > > fs/befs/debug.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/befs/debug.c b/fs/befs/debug.c > index 4de7cff..85c1339 100644 > --- a/fs/befs/debug.c > +++ b/fs/befs/debug.c > @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup) > > befs_debug(sb, " num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks)); > befs_debug(sb, " used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks)); > + befs_debug(sb, " inode_size %u", fs32_to_cpu(sb, sup->inode_size)); > > befs_debug(sb, " magic2 %08x", fs32_to_cpu(sb, sup->magic2)); > befs_debug(sb, " blocks_per_ag %u", > -- > 2.5.1 > Signed-off-by: Salah Triki <salah.triki@gmail.com> Thanx Salah
[toc] | [prev] | [next] | [standalone]
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Date | 2016-08-11 12:10 +0200 |
| Message-ID | <s4V62-2qB-45@gated-at.bofh.it> |
| In reply to | #1460016 |
On 10/08/16 22:41, Salah Triki wrote: > On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote: >> befs_dump_super_block() wasn't giving the inode_size information when >> dumping all elements of the superblock. Add this element to have complete >> information of the superblock. >> >> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> >> --- >> >> Hi, >> >> This is a series of superblock information related changes. >> >> Thanks, >> Luis >> >> fs/befs/debug.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/befs/debug.c b/fs/befs/debug.c >> index 4de7cff..85c1339 100644 >> --- a/fs/befs/debug.c >> +++ b/fs/befs/debug.c >> @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup) >> >> befs_debug(sb, " num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks)); >> befs_debug(sb, " used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks)); >> + befs_debug(sb, " inode_size %u", fs32_to_cpu(sb, sup->inode_size)); >> >> befs_debug(sb, " magic2 %08x", fs32_to_cpu(sb, sup->magic2)); >> befs_debug(sb, " blocks_per_ag %u", >> -- >> 2.5.1 >> > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > > Thanx > Salah > Hi Salah, I prefer applying this series as a set. So will wait for your review of patch 2/4. Let me know if you don't have time for it. Thanks for the reviews, Luis
[toc] | [prev] | [next] | [standalone]
| From | Salah Triki <salah.triki@gmail.com> |
|---|---|
| Date | 2016-08-11 16:10 +0200 |
| Message-ID | <s4YQi-4R3-27@gated-at.bofh.it> |
| In reply to | #1460361 |
On Thu, Aug 11, 2016 at 11:03:47AM +0100, Luis de Bethencourt wrote: > On 10/08/16 22:41, Salah Triki wrote: > > On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote: > >> befs_dump_super_block() wasn't giving the inode_size information when > >> dumping all elements of the superblock. Add this element to have complete > >> information of the superblock. > >> > >> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > >> --- > >> > >> Hi, > >> > >> This is a series of superblock information related changes. > >> > >> Thanks, > >> Luis > >> > >> fs/befs/debug.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/fs/befs/debug.c b/fs/befs/debug.c > >> index 4de7cff..85c1339 100644 > >> --- a/fs/befs/debug.c > >> +++ b/fs/befs/debug.c > >> @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup) > >> > >> befs_debug(sb, " num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks)); > >> befs_debug(sb, " used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks)); > >> + befs_debug(sb, " inode_size %u", fs32_to_cpu(sb, sup->inode_size)); > >> > >> befs_debug(sb, " magic2 %08x", fs32_to_cpu(sb, sup->magic2)); > >> befs_debug(sb, " blocks_per_ag %u", > >> -- > >> 2.5.1 > >> > > > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > > > > Thanx > > Salah > > > > Hi Salah, > > I prefer applying this series as a set. So will wait for your review of patch 2/4. > > Let me know if you don't have time for it. > > Thanks for the reviews, > Luis Hi Luis, I am reviewing the patch 2/4 regards, Salah
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web