Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1460361

Re: [PATCH 1/4] befs: dump inode_size superblock information

From Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/4] befs: dump inode_size superblock information
Date 2016-08-11 12:10 +0200
Message-ID <s4V62-2qB-45@gated-at.bofh.it> (permalink)
References <s4nnH-4Yg-9@gated-at.bofh.it> <s4JxT-2gM-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/08/16 22:41, Salah Triki wrote:
> On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote:
>> befs_dump_super_block() wasn't giving the inode_size information when
>> dumping all elements of the superblock. Add this element to have complete
>> information of the superblock.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>>
>> Hi,
>>
>> This is a series of superblock information related changes.
>>
>> Thanks,
>> Luis
>>
>>  fs/befs/debug.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/befs/debug.c b/fs/befs/debug.c
>> index 4de7cff..85c1339 100644
>> --- a/fs/befs/debug.c
>> +++ b/fs/befs/debug.c
>> @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup)
>>  
>>  	befs_debug(sb, "  num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks));
>>  	befs_debug(sb, "  used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks));
>> +	befs_debug(sb, "  inode_size %u", fs32_to_cpu(sb, sup->inode_size));
>>  
>>  	befs_debug(sb, "  magic2 %08x", fs32_to_cpu(sb, sup->magic2));
>>  	befs_debug(sb, "  blocks_per_ag %u",
>> -- 
>> 2.5.1
>>
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> 
> Thanx
> Salah
> 

Hi Salah,

I prefer applying this series as a set. So will wait for your review of patch 2/4.

Let me know if you don't have time for it.

Thanks for the reviews,
Luis

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/4] befs: dump inode_size superblock information Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-10 00:10 +0200
  Re: [PATCH 1/4] befs: dump inode_size superblock information Salah Triki <salah.triki@gmail.com> - 2016-08-10 23:50 +0200
    Re: [PATCH 1/4] befs: dump inode_size superblock information Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-11 12:10 +0200
      Re: [PATCH 1/4] befs: dump inode_size superblock information Salah Triki <salah.triki@gmail.com> - 2016-08-11 16:10 +0200

csiph-web