Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460050 > unrolled thread

[PATCH 4/4] befs: remove unnecessary initialization

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 4/4] befs: remove unnecessary initialization Salah Triki <salah.triki@gmail.com> - 2016-08-11 00:20 +0200
    Re: [PATCH 4/4] befs: remove unnecessary initialization Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-11 13:10 +0200

#1460050 — [PATCH 4/4] befs: remove unnecessary initialization

There is no need to init block, since it will be overwitten later by
iaddr2blockno().

Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
 fs/befs/io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/io.c b/fs/befs/io.c
index f9790f5..39d0dce 100644
--- a/fs/befs/io.c
+++ b/fs/befs/io.c
@@ -27,7 +27,7 @@ struct buffer_head *
 befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr)
 {
 	struct buffer_head *bh;
-	befs_blocknr_t block = 0;
+	befs_blocknr_t block;
 
 	befs_debug(sb, "---> Enter %s "
 		   "[%u, %hu, %hu]", __func__, iaddr.allocation_group,
-- 
1.9.1

[toc] | [next] | [standalone]

#1460407

On 10/08/16 23:12, Salah Triki wrote:
> There is no need to init block, since it will be overwitten later by
> iaddr2blockno().
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
>  fs/befs/io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/io.c b/fs/befs/io.c
> index f9790f5..39d0dce 100644
> --- a/fs/befs/io.c
> +++ b/fs/befs/io.c
> @@ -27,7 +27,7 @@ struct buffer_head *
>  befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr)
>  {
>  	struct buffer_head *bh;
> -	befs_blocknr_t block = 0;
> +	befs_blocknr_t block;
>  
>  	befs_debug(sb, "---> Enter %s "
>  		   "[%u, %hu, %hu]", __func__, iaddr.allocation_group,
> 

Applied and merged to:
https://github.com/luisbg/linux-befs/commits/for-next

Thanks Salah :)
Luis

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web