Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1460407

Re: [PATCH 4/4] befs: remove unnecessary initialization

From Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] befs: remove unnecessary initialization
Date 2016-08-11 13:10 +0200
Message-ID <s4W26-31e-21@gated-at.bofh.it> (permalink)
References <s4K0W-2GI-7@gated-at.bofh.it> <s4K0W-2GI-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/08/16 23:12, Salah Triki wrote:
> There is no need to init block, since it will be overwitten later by
> iaddr2blockno().
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
>  fs/befs/io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/io.c b/fs/befs/io.c
> index f9790f5..39d0dce 100644
> --- a/fs/befs/io.c
> +++ b/fs/befs/io.c
> @@ -27,7 +27,7 @@ struct buffer_head *
>  befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr)
>  {
>  	struct buffer_head *bh;
> -	befs_blocknr_t block = 0;
> +	befs_blocknr_t block;
>  
>  	befs_debug(sb, "---> Enter %s "
>  		   "[%u, %hu, %hu]", __func__, iaddr.allocation_group,
> 

Applied and merged to:
https://github.com/luisbg/linux-befs/commits/for-next

Thanks Salah :)
Luis

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 4/4] befs: remove unnecessary initialization Salah Triki <salah.triki@gmail.com> - 2016-08-11 00:20 +0200
  Re: [PATCH 4/4] befs: remove unnecessary initialization Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-11 13:10 +0200

csiph-web