Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452631 > unrolled thread
| Started by | Chen Feng <puck.chen@hisilicon.com> |
|---|---|
| First post | 2016-07-30 04:20 +0200 |
| Last post | 2016-08-08 20:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags Chen Feng <puck.chen@hisilicon.com> - 2016-07-30 04:20 +0200
Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags Laura Abbott <labbott@redhat.com> - 2016-08-08 20:50 +0200
| From | Chen Feng <puck.chen@hisilicon.com> |
|---|---|
| Date | 2016-07-30 04:20 +0200 |
| Subject | [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags |
| Message-ID | <s0s2B-4NV-5@gated-at.bofh.it> |
It's useful to show the current memory in detail when alloc failed.
And, there may be a lot of high order alloc failed, just show memory
when an order 0 alloc failed.
Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
---
drivers/staging/android/ion/ion_system_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
index b69dfc7..c3b7975 100644
--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -28,7 +28,7 @@
static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
__GFP_NORETRY) & ~__GFP_RECLAIM;
-static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
+static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO);
static const unsigned int orders[] = {8, 4, 0};
static const int num_orders = ARRAY_SIZE(orders);
static int order_to_index(unsigned int order)
--
1.9.1
[toc] | [next] | [standalone]
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-08-08 20:50 +0200 |
| Subject | Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags |
| Message-ID | <s3XMC-52s-11@gated-at.bofh.it> |
| In reply to | #1452631 |
On 07/29/2016 07:09 PM, Chen Feng wrote:
> It's useful to show the current memory in detail when alloc failed.
>
> And, there may be a lot of high order alloc failed, just show memory
> when an order 0 alloc failed.
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
> drivers/staging/android/ion/ion_system_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index b69dfc7..c3b7975 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -28,7 +28,7 @@
>
> static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
> __GFP_NORETRY) & ~__GFP_RECLAIM;
> -static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
> +static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO);
> static const unsigned int orders[] = {8, 4, 0};
> static const int num_orders = ARRAY_SIZE(orders);
> static int order_to_index(unsigned int order)
>
Acked-by: Laura Abbott <labbott@redhat.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web