Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags

From	Laura Abbott <labbott@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags
Date	2016-08-08 20:50 +0200
Message-ID	<s3XMC-52s-11@gated-at.bofh.it> (permalink)
References	<s0s2B-4NV-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/29/2016 07:09 PM, Chen Feng wrote:
> It's useful to show the current memory in detail when alloc failed.
>
> And, there may be a lot of high order alloc failed, just show memory
> when an order 0 alloc failed.
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
>  drivers/staging/android/ion/ion_system_heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index b69dfc7..c3b7975 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -28,7 +28,7 @@
>
>  static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
>  				     __GFP_NORETRY) & ~__GFP_RECLAIM;
> -static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
> +static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO);
>  static const unsigned int orders[] = {8, 4, 0};
>  static const int num_orders = ARRAY_SIZE(orders);
>  static int order_to_index(unsigned int order)
>

Acked-by: Laura Abbott <labbott@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags Chen Feng <puck.chen@hisilicon.com> - 2016-07-30 04:20 +0200
  Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp  flags Laura Abbott <labbott@redhat.com> - 2016-08-08 20:50 +0200

csiph-web