Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457801 > unrolled thread
| Started by | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2016-08-08 15:50 +0200 |
| Last post | 2016-08-08 16:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop Greg KH <gregkh@linuxfoundation.org> - 2016-08-08 15:50 +0200
Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop Dirk Eibach <dirk.eibach@gdsys.cc> - 2016-08-08 16:10 +0200
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-08-08 15:50 +0200 |
| Subject | Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop |
| Message-ID | <s3T6i-22X-17@gated-at.bofh.it> |
On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@gdsys.cc wrote: > From: Dirk Eibach <dirk.eibach@gdsys.cc> > > sc16is7xx_port_irq() is laid out as an endless loop. It will exit only > when there is no more interrupt left to service. This not common > practice. > In our case it lead to some strange hangup situation when there was an > unexpected XOFF-interrupt that could not be handled. > So let's service interrupts only once and report XOFF-interrupts that > should never happen since they are never enabled. > > Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc> > > Conflicts: > drivers/tty/serial/sc16is7xx.c Why are these 2 lines in here?
[toc] | [next] | [standalone]
| From | Dirk Eibach <dirk.eibach@gdsys.cc> |
|---|---|
| Date | 2016-08-08 16:10 +0200 |
| Message-ID | <s3TpE-2p3-29@gated-at.bofh.it> |
| In reply to | #1457801 |
2016-08-08 15:43 GMT+02:00 Greg KH <gregkh@linuxfoundation.org>: > On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@gdsys.cc wrote: >> From: Dirk Eibach <dirk.eibach@gdsys.cc> >> >> sc16is7xx_port_irq() is laid out as an endless loop. It will exit only >> when there is no more interrupt left to service. This not common >> practice. >> In our case it lead to some strange hangup situation when there was an >> unexpected XOFF-interrupt that could not be handled. >> So let's service interrupts only once and report XOFF-interrupts that >> should never happen since they are never enabled. >> >> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc> >> >> Conflicts: >> drivers/tty/serial/sc16is7xx.c > > Why are these 2 lines in here? Sorry, my bad. I have no idea how they slipped in. Will remove them in v2. Cheers Dirk
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web