Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457801

Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop
Date 2016-08-08 15:50 +0200
Message-ID <s3T6i-22X-17@gated-at.bofh.it> (permalink)
References <s3T6i-22X-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@gdsys.cc wrote:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
> 
> sc16is7xx_port_irq() is laid out as an endless loop. It will exit only
> when there is no more interrupt left to service. This not common
> practice.
> In our case it lead to some strange hangup situation when there was an
> unexpected XOFF-interrupt that could not be handled.
> So let's service interrupts only once and report XOFF-interrupts that
> should never happen since they are never enabled.
> 
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
> 
> Conflicts:
> 	drivers/tty/serial/sc16is7xx.c

Why are these 2 lines in here?

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop Greg KH <gregkh@linuxfoundation.org> - 2016-08-08 15:50 +0200
  Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop Dirk Eibach <dirk.eibach@gdsys.cc> - 2016-08-08 16:10 +0200

csiph-web