Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457597 > unrolled thread

Re: [PATCH] mfd: arizona: Remove pointless switch case

Started byCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
First post2016-08-08 10:10 +0200
Last post2016-08-08 10:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] mfd: arizona: Remove pointless switch case Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-08-08 10:10 +0200

#1457597 — Re: [PATCH] mfd: arizona: Remove pointless switch case

FromCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Date2016-08-08 10:10 +0200
SubjectRe: [PATCH] mfd: arizona: Remove pointless switch case
Message-ID<s3NNg-7fc-1@gated-at.bofh.it>
On Sat, Jul 23, 2016 at 07:41:13PM +0200, Bernd Petrovitsch wrote:
> Hi all!
> 
> On Fri, 2016-07-22 at 16:58 +0100, Charles Keepax wrote:
> [...]
> >  		case IRQF_TRIGGER_RISING:
> >  		case IRQF_TRIGGER_FALLING:
> >  			break;
> > -
> > -		case IRQ_TYPE_NONE:
> >  		default:
> 
> Don't know about the kernels coding rule in that case but personally, I
> use that style to explicit list all enum/#define values so that it is
> obvious that none was forgotten.
> For the compiler output, it shouldn't matter anyways ...
> 

I don't have any objection to dropping the patch as you say will
generate the same output either way.

Thanks,
Charles

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web