Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457597

Re: [PATCH] mfd: arizona: Remove pointless switch case

From Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mfd: arizona: Remove pointless switch case
Date 2016-08-08 10:10 +0200
Message-ID <s3NNg-7fc-1@gated-at.bofh.it> (permalink)
References <rXL1L-7Ib-1@gated-at.bofh.it> <rY9GN-62h-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jul 23, 2016 at 07:41:13PM +0200, Bernd Petrovitsch wrote:
> Hi all!
> 
> On Fri, 2016-07-22 at 16:58 +0100, Charles Keepax wrote:
> [...]
> >  		case IRQF_TRIGGER_RISING:
> >  		case IRQF_TRIGGER_FALLING:
> >  			break;
> > -
> > -		case IRQ_TYPE_NONE:
> >  		default:
> 
> Don't know about the kernels coding rule in that case but personally, I
> use that style to explicit list all enum/#define values so that it is
> obvious that none was forgotten.
> For the compiler output, it shouldn't matter anyways ...
> 

I don't have any objection to dropping the patch as you say will
generate the same output either way.

Thanks,
Charles

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] mfd: arizona: Remove pointless switch case Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-08-08 10:10 +0200

csiph-web