Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456186 > unrolled thread

Re: [patch] tty: amiserial.c: remove a double irq restore

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [patch] tty: amiserial.c: remove a double irq restore Jiri Slaby <jslaby@suse.cz> - 2016-08-04 08:30 +0200
    Re: [patch] tty: amiserial.c: remove a double irq restore Dan Carpenter <dan.carpenter@oracle.com> - 2016-08-04 12:20 +0200

#1456186 — Re: [patch] tty: amiserial.c: remove a double irq restore

On 08/04/2016, 07:34 AM, Dan Carpenter wrote:
> We already called "local_irq_restore(flags);" so this isn't needed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 208f573..2f33cf1 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count

If I add a bit more context:

                local_irq_disable();
                custom.intena = IF_SETCLR | IF_TBE;
                mb();
>  		/* set a pending Tx Interrupt, transmitter should restart now */
>  		custom.intreq = IF_SETCLR | IF_TBE;
>  		mb();
> -		local_irq_restore(flags);

Really?

thanks,
-- 
js
suse labs

[toc] | [next] | [standalone]

#1456299

Oh...  Wow.  I'm really sorry about that.  Thanks for catching the
mistake.

It should as well have been caught by static analysis but it wasn't.
I will work on this so it doesn't happen again.  And I will try to be
more careful as well.

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web