Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1456183 > unrolled thread

[PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()

Started byLin Huang <hl@rock-chips.com>
First post2016-08-04 08:10 +0200
Last post2016-08-04 10:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata() Lin Huang <hl@rock-chips.com> - 2016-08-04 08:10 +0200
    Re: [PATCH] PM / devfreq: event: remove duplicate  devfreq_event_get_drvdata() Chanwoo Choi <cw00.choi@samsung.com> - 2016-08-04 10:50 +0200

#1456183 — [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()

FromLin Huang <hl@rock-chips.com>
Date2016-08-04 08:10 +0200
Subject[PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
Message-ID<s2k0V-53V-5@gated-at.bofh.it>
there define two devfreq_event_get_drvdata() function in devfreq-event.h
when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
remove devfreq_event_get_drvdata() function.

Signed-off-by: Lin Huang <hl@rock-chips.com>
---
 include/linux/devfreq-event.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
index 0a83a1e..4db00b0 100644
--- a/include/linux/devfreq-event.h
+++ b/include/linux/devfreq-event.h
@@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
 	return -EINVAL;
 }
 
-static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
-{
-	return ERR_PTR(-EINVAL);
-}
-
 static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
 					struct device *dev, int index)
 {
-- 
1.9.1

[toc] | [next] | [standalone]


#1456217 — Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-08-04 10:50 +0200
SubjectRe: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
Message-ID<s2mvL-6x9-3@gated-at.bofh.it>
In reply to#1456183
+ Myungjoo Ham,

Hi Lin Huang,

On 2016년 08월 04일 15:01, Lin Huang wrote:
> there define two devfreq_event_get_drvdata() function in devfreq-event.h
> when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
> remove devfreq_event_get_drvdata() function.
> 
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
>  include/linux/devfreq-event.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
> index 0a83a1e..4db00b0 100644
> --- a/include/linux/devfreq-event.h
> +++ b/include/linux/devfreq-event.h
> @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
>  	return -EINVAL;
>  }
>  
> -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
> -{
> -	return ERR_PTR(-EINVAL);
> -}
> -
>  static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
>  					struct device *dev, int index)
>  {
> 

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Regards,
Chanwoo Choi

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web