Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
Date	2016-08-04 10:50 +0200
Message-ID	<s2mvL-6x9-3@gated-at.bofh.it> (permalink)
References	<s2mvL-6x9-5@gated-at.bofh.it> <s2k0V-53V-5@gated-at.bofh.it>
Organization	Samsung Electronics

Show all headers | View raw

+ Myungjoo Ham,

Hi Lin Huang,

On 2016년 08월 04일 15:01, Lin Huang wrote:
> there define two devfreq_event_get_drvdata() function in devfreq-event.h
> when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
> remove devfreq_event_get_drvdata() function.
> 
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
>  include/linux/devfreq-event.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
> index 0a83a1e..4db00b0 100644
> --- a/include/linux/devfreq-event.h
> +++ b/include/linux/devfreq-event.h
> @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
>  	return -EINVAL;
>  }
>  
> -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
> -{
> -	return ERR_PTR(-EINVAL);
> -}
> -
>  static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
>  					struct device *dev, int index)
>  {
> 

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Regards,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata() Lin Huang <hl@rock-chips.com> - 2016-08-04 08:10 +0200
  Re: [PATCH] PM / devfreq: event: remove duplicate  devfreq_event_get_drvdata() Chanwoo Choi <cw00.choi@samsung.com> - 2016-08-04 10:50 +0200

csiph-web