Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456016 > unrolled thread

[PATCH] slub: Drop bogus inline for fixup_red_left()

Back to article view | Back to linux.kernel

Contents

  [PATCH] slub: Drop bogus inline for fixup_red_left() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-03 22:40 +0200
    Re: [PATCH] slub: Drop bogus inline for fixup_red_left() David Rientjes <rientjes@google.com> - 2016-08-04 01:50 +0200

#1456016 — [PATCH] slub: Drop bogus inline for fixup_red_left()

With m68k-linux-gnu-gcc-4.1:

    include/linux/slub_def.h:126: warning: ‘fixup_red_left’ declared inline after being called
    include/linux/slub_def.h:126: warning: previous declaration of ‘fixup_red_left’ was here

Commit c146a2b98eb5898e ("mm, kasan: account for object redzone in
SLUB's nearest_obj()") made fixup_red_left() global, but forgot to
remove the inline keyword.

Fixes: c146a2b98eb5898e ("mm, kasan: account for object redzone in SLUB's nearest_obj()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 mm/slub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 26eb6a99540e8530..850737bdfbd82410 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -124,7 +124,7 @@ static inline int kmem_cache_debug(struct kmem_cache *s)
 #endif
 }
 
-inline void *fixup_red_left(struct kmem_cache *s, void *p)
+void *fixup_red_left(struct kmem_cache *s, void *p)
 {
 	if (kmem_cache_debug(s) && s->flags & SLAB_RED_ZONE)
 		p += s->red_left_pad;
-- 
1.9.1

[toc] | [next] | [standalone]

#1456073

[Multipart message — attachments visible in raw view] — view raw

On Wed, 3 Aug 2016, Geert Uytterhoeven wrote:

> With m68k-linux-gnu-gcc-4.1:
> 
>     include/linux/slub_def.h:126: warning: ‘fixup_red_left’ declared inline after being called
>     include/linux/slub_def.h:126: warning: previous declaration of ‘fixup_red_left’ was here
> 
> Commit c146a2b98eb5898e ("mm, kasan: account for object redzone in
> SLUB's nearest_obj()") made fixup_red_left() global, but forgot to
> remove the inline keyword.
> 
> Fixes: c146a2b98eb5898e ("mm, kasan: account for object redzone in SLUB's nearest_obj()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: David Rientjes <rientjes@google.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web