[PATCH] slub: Drop bogus inline for fixup_red_left()

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	[PATCH] slub: Drop bogus inline for fixup_red_left()
Date	2016-08-03 22:40 +0200
Message-ID	<s2b7k-7uo-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

With m68k-linux-gnu-gcc-4.1:

    include/linux/slub_def.h:126: warning: ‘fixup_red_left’ declared inline after being called
    include/linux/slub_def.h:126: warning: previous declaration of ‘fixup_red_left’ was here

Commit c146a2b98eb5898e ("mm, kasan: account for object redzone in
SLUB's nearest_obj()") made fixup_red_left() global, but forgot to
remove the inline keyword.

Fixes: c146a2b98eb5898e ("mm, kasan: account for object redzone in SLUB's nearest_obj()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 mm/slub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 26eb6a99540e8530..850737bdfbd82410 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -124,7 +124,7 @@ static inline int kmem_cache_debug(struct kmem_cache *s)
 #endif
 }
 
-inline void *fixup_red_left(struct kmem_cache *s, void *p)
+void *fixup_red_left(struct kmem_cache *s, void *p)
 {
 	if (kmem_cache_debug(s) && s->flags & SLAB_RED_ZONE)
 		p += s->red_left_pad;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] slub: Drop bogus inline for fixup_red_left() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-03 22:40 +0200
  Re: [PATCH] slub: Drop bogus inline for fixup_red_left() David Rientjes <rientjes@google.com> - 2016-08-04 01:50 +0200

csiph-web