Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456818 > unrolled thread
| Started by | Andrew Donnellan <andrew.donnellan@au1.ibm.com> |
|---|---|
| First post | 2016-08-05 01:40 +0200 |
| Last post | 2016-08-05 14:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-08-05 01:40 +0200
Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac Borislav Petkov <bp@alien8.de> - 2016-08-05 09:00 +0200
Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac york sun <york.sun@nxp.com> - 2016-08-05 14:20 +0200
| From | Andrew Donnellan <andrew.donnellan@au1.ibm.com> |
|---|---|
| Date | 2016-08-05 01:40 +0200 |
| Subject | Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac |
| Message-ID | <s2Ap4-8cT-5@gated-at.bofh.it> |
On 05/08/16 08:58, York Sun wrote:
> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
Good catch! One comment below.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> /*
> * Reads the interrupt pin to determine if interrupt is use by card.
> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
> {
> return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
> }
> +EXPORT_SYMBOL(early_find_capability);
It'd be nicer for this to be renamed as "pci_early_find_capability" or
something like that with a "namespace", I think.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-08-05 09:00 +0200 |
| Message-ID | <s2HgR-40X-5@gated-at.bofh.it> |
| In reply to | #1456818 |
On Thu, Aug 04, 2016 at 11:39:14PM +0000, york sun wrote:
> I will rename it if I respin this patch for any reason. Otherwise, I
> will send out another patch to rename it after merging.
Feel free to send an updated one as a reply to this thread.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
[toc] | [prev] | [next] | [standalone]
| From | york sun <york.sun@nxp.com> |
|---|---|
| Date | 2016-08-05 14:20 +0200 |
| Message-ID | <s2HgR-40X-7@gated-at.bofh.it> |
| In reply to | #1456818 |
On 08/04/2016 04:36 PM, Andrew Donnellan wrote:
> On 05/08/16 08:58, York Sun wrote:
>> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>>
>> Signed-off-by: York Sun <york.sun@nxp.com>
>
> Good catch! One comment below.
>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
>> /*
>> * Reads the interrupt pin to determine if interrupt is use by card.
>> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>> {
>> return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
>> }
>> +EXPORT_SYMBOL(early_find_capability);
>
> It'd be nicer for this to be renamed as "pci_early_find_capability" or
> something like that with a "namespace", I think.
>
I will rename it if I respin this patch for any reason. Otherwise, I
will send out another patch to rename it after merging.
York
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web