Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

From	york sun <york.sun@nxp.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
Date	2016-08-05 14:20 +0200
Message-ID	<s2HgR-40X-7@gated-at.bofh.it> (permalink)
References	<s2Ap4-8cT-7@gated-at.bofh.it> <s2Ap4-8cT-9@gated-at.bofh.it> <s2Ap4-8cT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/04/2016 04:36 PM, Andrew Donnellan wrote:
> On 05/08/16 08:58, York Sun wrote:
>> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>>
>> Signed-off-by: York Sun <york.sun@nxp.com>
>
> Good catch! One comment below.
>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
>>  /*
>>   * Reads the interrupt pin to determine if interrupt is use by card.
>> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>>  {
>>  	return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
>>  }
>> +EXPORT_SYMBOL(early_find_capability);
>
> It'd be nicer for this to be renamed as "pci_early_find_capability" or
> something like that with a "namespace", I think.
>

I will rename it if I respin this patch for any reason. Otherwise, I 
will send out another patch to rename it after merging.

York

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-08-05 01:40 +0200
  Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac Borislav Petkov <bp@alien8.de> - 2016-08-05 09:00 +0200
  Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac york sun <york.sun@nxp.com> - 2016-08-05 14:20 +0200

csiph-web