Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1452344 > unrolled thread

[PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support

Started byBibby Hsieh <bibby.hsieh@mediatek.com>
First post2016-07-29 11:20 +0200
Last post2016-08-03 03:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support Bibby Hsieh <bibby.hsieh@mediatek.com> - 2016-07-29 11:20 +0200
    Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-29 12:00 +0200
      Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support Bibby Hsieh <bibby.hsieh@mediatek.com> - 2016-08-03 03:50 +0200

#1452344 — [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support

FromBibby Hsieh <bibby.hsieh@mediatek.com>
Date2016-07-29 11:20 +0200
Subject[PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support
Message-ID<s0c7v-2I1-9@gated-at.bofh.it>
To support HDMI 4K resolution, mmsys need clcok
mm_sel to be 400MHz.

The board .dts file should override the clock rate
property with the higher VENCPLL frequency the board
supports HDMI 4K resolution.

Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 78529e4..93d4d17 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -690,6 +690,8 @@
 			compatible = "mediatek,mt8173-mmsys", "syscon";
 			reg = <0 0x14000000 0 0x1000>;
 			power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
+			clocks = <&topckgen CLK_TOP_MM_SEL>;
+			clock-frequency  = <400000000>;
 			#clock-cells = <1>;
 		};
 
-- 
1.7.9.5

[toc] | [next] | [standalone]


#1452361

FromPhilipp Zabel <p.zabel@pengutronix.de>
Date2016-07-29 12:00 +0200
Message-ID<s0cKi-2Vf-5@gated-at.bofh.it>
In reply to#1452344
Hi Bibby,

Am Freitag, den 29.07.2016, 17:09 +0800 schrieb Bibby Hsieh:
> To support HDMI 4K resolution, mmsys need clcok
> mm_sel to be 400MHz.
> 
> The board .dts file should override the clock rate
> property with the higher VENCPLL frequency the board
> supports HDMI 4K resolution.
> 
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 78529e4..93d4d17 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -690,6 +690,8 @@
>  			compatible = "mediatek,mt8173-mmsys", "syscon";
>  			reg = <0 0x14000000 0 0x1000>;
>  			power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> +			clocks = <&topckgen CLK_TOP_MM_SEL>;
> +			clock-frequency  = <400000000>;

This is unchanged compared to v3, I suggest to use assigned-clocks /
assigned-clock-rates properties instead.

best regards
Philipp

[toc] | [prev] | [next] | [standalone]


#1455573

FromBibby Hsieh <bibby.hsieh@mediatek.com>
Date2016-08-03 03:50 +0200
Message-ID<s1TtL-45W-3@gated-at.bofh.it>
In reply to#1452361
Hi, Philipp,

On Fri, 2016-07-29 at 11:53 +0200, Philipp Zabel wrote:
> Hi Bibby,
> 
> Am Freitag, den 29.07.2016, 17:09 +0800 schrieb Bibby Hsieh:
> > To support HDMI 4K resolution, mmsys need clcok
> > mm_sel to be 400MHz.
> > 
> > The board .dts file should override the clock rate
> > property with the higher VENCPLL frequency the board
> > supports HDMI 4K resolution.
> > 
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 78529e4..93d4d17 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -690,6 +690,8 @@
> >  			compatible = "mediatek,mt8173-mmsys", "syscon";
> >  			reg = <0 0x14000000 0 0x1000>;
> >  			power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > +			clocks = <&topckgen CLK_TOP_MM_SEL>;
> > +			clock-frequency  = <400000000>;
> 
> This is unchanged compared to v3, I suggest to use assigned-clocks /
> assigned-clock-rates properties instead.
> 
Ok, I will change that, thanks for your review.

-- 
Bibby
> best regards
> Philipp
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web