Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1455573

Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support

From Bibby Hsieh <bibby.hsieh@mediatek.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support
Date 2016-08-03 03:50 +0200
Message-ID <s1TtL-45W-3@gated-at.bofh.it> (permalink)
References <s0c7v-2I1-9@gated-at.bofh.it> <s0cKi-2Vf-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi, Philipp,

On Fri, 2016-07-29 at 11:53 +0200, Philipp Zabel wrote:
> Hi Bibby,
> 
> Am Freitag, den 29.07.2016, 17:09 +0800 schrieb Bibby Hsieh:
> > To support HDMI 4K resolution, mmsys need clcok
> > mm_sel to be 400MHz.
> > 
> > The board .dts file should override the clock rate
> > property with the higher VENCPLL frequency the board
> > supports HDMI 4K resolution.
> > 
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 78529e4..93d4d17 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -690,6 +690,8 @@
> >  			compatible = "mediatek,mt8173-mmsys", "syscon";
> >  			reg = <0 0x14000000 0 0x1000>;
> >  			power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > +			clocks = <&topckgen CLK_TOP_MM_SEL>;
> > +			clock-frequency  = <400000000>;
> 
> This is unchanged compared to v3, I suggest to use assigned-clocks /
> assigned-clock-rates properties instead.
> 
Ok, I will change that, thanks for your review.

-- 
Bibby
> best regards
> Philipp
> 

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support Bibby Hsieh <bibby.hsieh@mediatek.com> - 2016-07-29 11:20 +0200
  Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-29 12:00 +0200
    Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support Bibby Hsieh <bibby.hsieh@mediatek.com> - 2016-08-03 03:50 +0200

csiph-web