Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1455400 > unrolled thread
| Started by | Alexandre Bounine <alexandre.bounine@idt.com> |
|---|---|
| First post | 2016-08-02 21:00 +0200 |
| Last post | 2016-08-02 23:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2 Alexandre Bounine <alexandre.bounine@idt.com> - 2016-08-02 21:00 +0200
Re: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2 Andrew Morton <akpm@linux-foundation.org> - 2016-08-02 21:30 +0200
RE: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2 "Bounine, Alexandre" <Alexandre.Bounine@idt.com> - 2016-08-02 23:10 +0200
| From | Alexandre Bounine <alexandre.bounine@idt.com> |
|---|---|
| Date | 2016-08-02 21:00 +0200 |
| Subject | [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2 |
| Message-ID | <s1N50-8oW-37@gated-at.bofh.it> |
Fix compile error reported by Michael Ellerman: https://lkml.org/lkml/2016/7/27/14 also corrects fix: https://lkml.org/lkml/2016/7/27/488 Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com> Cc: Matt Porter <mporter@kernel.crashing.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com> Cc: Barry Wood <barry.wood@idt.com> Cc: linux-kernel@vger.kernel.org --- arch/powerpc/sysdev/fsl_rio.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c index f03930c..984e816 100644 --- a/arch/powerpc/sysdev/fsl_rio.c +++ b/arch/powerpc/sysdev/fsl_rio.c @@ -697,6 +697,9 @@ int fsl_rio_setup(struct platform_device *dev) ((i == 0) ? RIO_INB_ATMU_REGS_PORT1_OFFSET : RIO_INB_ATMU_REGS_PORT2_OFFSET)); + /* Set to receive packets with any dest ID */ + out_be32((priv->regs_win + RIO_ISR_AACR + i*0x80), + RIO_ISR_AACR_AA); /* Configure maintenance transaction window */ out_be32(&priv->maint_atmu_regs->rowbar, -- 1.7.8.4
[toc] | [next] | [standalone]
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2016-08-02 21:30 +0200 |
| Subject | Re: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2 |
| Message-ID | <s1Ny1-s4-7@gated-at.bofh.it> |
| In reply to | #1455400 |
On Tue, 2 Aug 2016 14:49:32 -0400 Alexandre Bounine <alexandre.bounine@idt.com> wrote: > Fix compile error reported by Michael Ellerman: > https://lkml.org/lkml/2016/7/27/14 > also corrects fix: https://lkml.org/lkml/2016/7/27/488 > > --- a/arch/powerpc/sysdev/fsl_rio.c > +++ b/arch/powerpc/sysdev/fsl_rio.c > @@ -697,6 +697,9 @@ int fsl_rio_setup(struct platform_device *dev) > ((i == 0) ? RIO_INB_ATMU_REGS_PORT1_OFFSET : > RIO_INB_ATMU_REGS_PORT2_OFFSET)); > > + /* Set to receive packets with any dest ID */ > + out_be32((priv->regs_win + RIO_ISR_AACR + i*0x80), > + RIO_ISR_AACR_AA); > > /* Configure maintenance transaction window */ > out_be32(&priv->maint_atmu_regs->rowbar, Confused. This doesn't fix a compile error. I'll assume I just add this to https://lkml.org/lkml/2016/7/27/488.
[toc] | [prev] | [next] | [standalone]
| From | "Bounine, Alexandre" <Alexandre.Bounine@idt.com> |
|---|---|
| Date | 2016-08-02 23:10 +0200 |
| Subject | RE: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2 |
| Message-ID | <s1P6N-1xu-7@gated-at.bofh.it> |
| In reply to | #1455422 |
> -----Original Message----- > From: Andrew Morton [mailto:akpm@linux-foundation.org] > Sent: Tuesday, August 02, 2016 3:26 PM > To: Bounine, Alexandre > Cc: Matt Porter; Michael Ellerman; Andre van Herk; Wood, Barry; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec > rev 3 fix2 > > On Tue, 2 Aug 2016 14:49:32 -0400 Alexandre Bounine > <alexandre.bounine@idt.com> wrote: > > > Fix compile error reported by Michael Ellerman: > > https://lkml.org/lkml/2016/7/27/14 > > also corrects fix: https://lkml.org/lkml/2016/7/27/488 > > > > --- a/arch/powerpc/sysdev/fsl_rio.c > > +++ b/arch/powerpc/sysdev/fsl_rio.c > > @@ -697,6 +697,9 @@ int fsl_rio_setup(struct platform_device *dev) > > ((i == 0) ? RIO_INB_ATMU_REGS_PORT1_OFFSET : > > RIO_INB_ATMU_REGS_PORT2_OFFSET)); > > > > + /* Set to receive packets with any dest ID */ > > + out_be32((priv->regs_win + RIO_ISR_AACR + i*0x80), > > + RIO_ISR_AACR_AA); > > > > /* Configure maintenance transaction window */ > > out_be32(&priv->maint_atmu_regs->rowbar, > > Confused. This doesn't fix a compile error. I'll assume I just add > this to https://lkml.org/lkml/2016/7/27/488. I referenced compile error reported in original Michael's email. In your patch, write to the register was removed together with port type check. In RIO spec v3 all ports are serial, therefore only the "if" line should be removed with write to the register remaining.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web