RE: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2

From	"Bounine, Alexandre" <Alexandre.Bounine@idt.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2
Date	2016-08-02 23:10 +0200
Message-ID	<s1P6N-1xu-7@gated-at.bofh.it> (permalink)
References	<s1N50-8oW-37@gated-at.bofh.it> <s1Ny1-s4-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Tuesday, August 02, 2016 3:26 PM
> To: Bounine, Alexandre
> Cc: Matt Porter; Michael Ellerman; Andre van Herk; Wood, Barry; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec
> rev 3 fix2
> 
> On Tue,  2 Aug 2016 14:49:32 -0400 Alexandre Bounine
> <alexandre.bounine@idt.com> wrote:
> 
> > Fix compile error reported by Michael Ellerman:
> > 		https://lkml.org/lkml/2016/7/27/14
> > also corrects fix: https://lkml.org/lkml/2016/7/27/488
> >
> > --- a/arch/powerpc/sysdev/fsl_rio.c
> > +++ b/arch/powerpc/sysdev/fsl_rio.c
> > @@ -697,6 +697,9 @@ int fsl_rio_setup(struct platform_device *dev)
> >  			((i == 0) ? RIO_INB_ATMU_REGS_PORT1_OFFSET :
> >  			RIO_INB_ATMU_REGS_PORT2_OFFSET));
> >
> > +		/* Set to receive packets with any dest ID */
> > +		out_be32((priv->regs_win + RIO_ISR_AACR + i*0x80),
> > +			 RIO_ISR_AACR_AA);
> >
> >  		/* Configure maintenance transaction window */
> >  		out_be32(&priv->maint_atmu_regs->rowbar,
> 
> Confused.  This doesn't fix a compile error.  I'll assume I just add
> this to https://lkml.org/lkml/2016/7/27/488.

I referenced compile error reported in original Michael's email.

In your patch, write to the register was removed together with port type check. In RIO spec v3 all ports are serial, therefore only the "if" line should be removed with write to the register remaining.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2 Alexandre Bounine <alexandre.bounine@idt.com> - 2016-08-02 21:00 +0200
  Re: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3  fix2 Andrew Morton <akpm@linux-foundation.org> - 2016-08-02 21:30 +0200
    RE: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3  fix2 "Bounine, Alexandre" <Alexandre.Bounine@idt.com> - 2016-08-02 23:10 +0200

csiph-web