Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454362 > unrolled thread

Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with  macro One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-08-02 15:30 +0200
    Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with  macro Masami Hiramatsu <mhiramat@kernel.org> - 2016-08-02 17:10 +0200

#1454362 — Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro

On Tue,  2 Aug 2016 18:33:22 +0800
Baole Ni <baolex.ni@intel.com> wrote:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

If you are going to do this then please generate one patch per subsystem,
and just do a couple of subsystems initially until everyone is happy with
how it is being converted, then send out more subsystem by subsystem.

Alan

[toc] | [next] | [standalone]

#1454684

On Tue, 2 Aug 2016 14:15:03 +0100
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> wrote:

> On Tue,  2 Aug 2016 18:33:22 +0800
> Baole Ni <baolex.ni@intel.com> wrote:
> 
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> 
> If you are going to do this then please generate one patch per subsystem,
> and just do a couple of subsystems initially until everyone is happy with
> how it is being converted, then send out more subsystem by subsystem.

+1

Moreover, please DO NOT use same subject and same description for each patch (explain
what you did and why for each one), unless it will be just spamming git-log...

Thank you,


-- 
Masami Hiramatsu <mhiramat@kernel.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web