Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1454362

Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro

From One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro
Date 2016-08-02 15:30 +0200
Message-ID <s1HVF-50V-79@gated-at.bofh.it> (permalink)
References <s1HVF-50V-81@gated-at.bofh.it>
Organization Intel Corporation

Show all headers | View raw


On Tue,  2 Aug 2016 18:33:22 +0800
Baole Ni <baolex.ni@intel.com> wrote:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

If you are going to do this then please generate one patch per subsystem,
and just do a couple of subsystems initially until everyone is happy with
how it is being converted, then send out more subsystem by subsystem.

Alan

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with  macro One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-08-02 15:30 +0200
  Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with  macro Masami Hiramatsu <mhiramat@kernel.org> - 2016-08-02 17:10 +0200

csiph-web