Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1400704 > unrolled thread
| Started by | Mark Brown <broonie@kernel.org> |
|---|---|
| First post | 2016-05-13 13:20 +0200 |
| Last post | 2016-05-16 04:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-05-13 13:20 +0200
Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-05-16 04:10 +0200
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-05-13 13:20 +0200 |
| Subject | Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface |
| Message-ID | <ryjiq-2bj-25@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote: > + gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS); > + if (IS_ERR(gpiod)) > + return ERR_PTR(-ENODEV); > + config->gpio = desc_to_gpio(gpiod); > + config->enable_high = device_property_read_bool(dev, > + "enable-active-high"); > + gpiod_put(gpiod); This isn't going to work at all if the GPIO is shared between multiple regulators but I can't immediately see a sensible way to fix that without some surgery on the GPIO APIs so let's leave it for now.
[toc] | [next] | [standalone]
| From | Lu Baolu <baolu.lu@linux.intel.com> |
|---|---|
| Date | 2016-05-16 04:10 +0200 |
| Message-ID | <rzg8T-u7-159@gated-at.bofh.it> |
| In reply to | #1400704 |
Hi, On 05/13/2016 07:17 PM, Mark Brown wrote: > On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote: > >> + gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS); >> + if (IS_ERR(gpiod)) >> + return ERR_PTR(-ENODEV); >> + config->gpio = desc_to_gpio(gpiod); >> + config->enable_high = device_property_read_bool(dev, >> + "enable-active-high"); >> + gpiod_put(gpiod); > This isn't going to work at all if the GPIO is shared between multiple > regulators but I can't immediately see a sensible way to fix that > without some surgery on the GPIO APIs so let's leave it for now. Okay. Thanks. Best regards, Lu Baolu
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web