Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface

From	Lu Baolu <baolu.lu@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface
Date	2016-05-16 04:10 +0200
Message-ID	<rzg8T-u7-159@gated-at.bofh.it> (permalink)
References	<rvkaZ-23G-3@gated-at.bofh.it> <rvkb0-23G-13@gated-at.bofh.it> <ryjiq-2bj-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 05/13/2016 07:17 PM, Mark Brown wrote:
> On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote:
>
>> +	gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS);
>> +	if (IS_ERR(gpiod))
>> +		return ERR_PTR(-ENODEV);
>> +	config->gpio = desc_to_gpio(gpiod);
>> +	config->enable_high = device_property_read_bool(dev,
>> +							"enable-active-high");
>> +	gpiod_put(gpiod);
> This isn't going to work at all if the GPIO is shared between multiple
> regulators but I can't immediately see a sensible way to fix that
> without some surgery on the GPIO APIs so let's leave it for now.

Okay. Thanks.

Best regards,
Lu Baolu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-05-13 13:20 +0200
  Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-05-16 04:10 +0200

csiph-web