Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401658 > unrolled thread

[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

Started byAmit Ghadge <amitg.b14@gmail.com>
First post2016-05-16 19:40 +0200
Last post2016-05-18 03:30 +0200
Articles 7 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-16 19:40 +0200
    Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Greg KH <gregkh@linuxfoundation.org> - 2016-05-16 20:40 +0200
      Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-17 05:30 +0200
        Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Greg KH <gregkh@linuxfoundation.org> - 2016-05-17 05:40 +0200
          Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-17 06:10 +0200
            Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Greg KH <gregkh@linuxfoundation.org> - 2016-05-17 15:50 +0200
              Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-18 03:30 +0200

#1401658 — [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

FromAmit Ghadge <amitg.b14@gmail.com>
Date2016-05-16 19:40 +0200
Subject[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
Message-ID<rzuEO-1xT-21@gated-at.bofh.it>
Fixed a warning issue to use 'unsigned int'.

Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
---
 drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
 	outb(0, dev->iobase + DAQP_AUX_REG);
 
 	for (i = 0; i > insn->n; i++) {
-		unsigned val = data[i];
+		unsigned int val = data[i];
 		int ret;
 
 		/* D/A transfer rate is about 8ms */
-- 
2.5.5

[toc] | [next] | [standalone]

#1401690

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-05-16 20:40 +0200
Message-ID<rzvAR-28G-7@gated-at.bofh.it>
In reply to#1401658
On Mon, May 16, 2016 at 11:04:31PM +0530, Amit Ghadge wrote:
> Fixed a warning issue to use 'unsigned int'.
> 

build warning?  I don't see that anywhere in the build output.

Please be specific.

[toc] | [prev] | [next] | [standalone]

#1402062

FromAmit Ghadge <amitg.b14@gmail.com>
Date2016-05-17 05:30 +0200
Message-ID<rzDRM-7AH-5@gated-at.bofh.it>
In reply to#1401690
I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message,

"drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'"

This patch reduced the warning message.

On Mon, May 16, 2016 at 11:19:05AM -0700, Greg KH wrote:
> On Mon, May 16, 2016 at 11:04:31PM +0530, Amit Ghadge wrote:
> > Fixed a warning issue to use 'unsigned int'.
> > 
> 
> build warning?  I don't see that anywhere in the build output.
> 
> Please be specific.

[toc] | [prev] | [next] | [standalone]

#1402065

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-05-17 05:40 +0200
Message-ID<rzE1r-7E7-3@gated-at.bofh.it>
In reply to#1402062
A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote:
> I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message,
> 
> "drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'"
> 
> This patch reduced the warning message.

Why didn't you put that information in the changelog area?

Please do so.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1402091

FromAmit Ghadge <amitg.b14@gmail.com>
Date2016-05-17 06:10 +0200
Message-ID<rzEut-83m-3@gated-at.bofh.it>
In reply to#1402065
Hello Greg KH,

I make patch same like other, I'm new and I nerver see changelog in other patches.

Where to add changelog? I followed you are tutorial.

Thanks,
Amit Ghadge
On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote:
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote:
> > I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message,
> > 
> > drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> > 
> > This patch reduced the warning message.
> 
> Why didn't you put that information in the changelog area?
> 
> Please do so.
> 
> greg k-h

[toc] | [prev] | [next] | [standalone]

#1402352

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-05-17 15:50 +0200
Message-ID<rzNxM-5cf-17@gated-at.bofh.it>
In reply to#1402091
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, May 17, 2016 at 09:31:56AM +0530, Amit Ghadge wrote:
> Hello Greg KH,
> 
> I make patch same like other, I'm new and I nerver see changelog in other patches.
> 
> Where to add changelog? I followed you are tutorial.

It's the area in the email before the patch, it ends up in the changelog
when the patch is committed to the kernel tree.  You wrote something
this time, but it was vague and didn't make sense.  Please fix that up
and resend.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1402689

FromAmit Ghadge <amitg.b14@gmail.com>
Date2016-05-18 03:30 +0200
Message-ID<rzYtc-3J2-21@gated-at.bofh.it>
In reply to#1402352
On Tue, May 17, 2016 at 06:47:56AM -0700, Greg KH wrote:
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> http://daringfireball.net/2007/07/on_top
Thanks for this valuable information.

> 
> On Tue, May 17, 2016 at 09:31:56AM +0530, Amit Ghadge wrote:
> > Hello Greg KH,
> > 
> > I make patch same like other, I'm new and I nerver see changelog in other patches.
> > 
> > Where to add changelog? I followed you are tutorial.
> 
> It's the area in the email before the patch, it ends up in the changelog
> when the patch is committed to the kernel tree.  You wrote something
> this time, but it was vague and didn't make sense.  Please fix that up
> and resend.
I resend this patch with patch description.

> 
> greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web