Groups > linux.kernel > #1402091

Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

From	Amit Ghadge <amitg.b14@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
Date	2016-05-17 06:10 +0200
Message-ID	<rzEut-83m-3@gated-at.bofh.it> (permalink)
References	<rzuEO-1xT-21@gated-at.bofh.it> <rzvAR-28G-7@gated-at.bofh.it> <rzDRM-7AH-5@gated-at.bofh.it> <rzE1r-7E7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Greg KH,

I make patch same like other, I'm new and I nerver see changelog in other patches.

Where to add changelog? I followed you are tutorial.

Thanks,
Amit Ghadge
On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote:
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote:
> > I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message,
> > 
> > drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> > 
> > This patch reduced the warning message.
> 
> Why didn't you put that information in the changelog area?
> 
> Please do so.
> 
> greg k-h

Thread

[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-16 19:40 +0200
  Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Greg KH <gregkh@linuxfoundation.org> - 2016-05-16 20:40 +0200
    Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-17 05:30 +0200
      Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Greg KH <gregkh@linuxfoundation.org> - 2016-05-17 05:40 +0200
        Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-17 06:10 +0200
          Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Greg KH <gregkh@linuxfoundation.org> - 2016-05-17 15:50 +0200
            Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge <amitg.b14@gmail.com> - 2016-05-18 03:30 +0200

csiph-web