Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401070 > unrolled thread

Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Vinod Koul <vinod.koul@intel.com> - 2016-05-14 10:00 +0200
    Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-05-24 12:00 +0200
      Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Vinod Koul <vinod.koul@intel.com> - 2016-05-26 17:30 +0200

#1401070 — Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()

On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current rcar_dmac_desc_put() is using list_add_tail() in order to
> push used descriptor to list of free descriptors, and next DMA transfer
> try to reuse it from this list. But because it is using *_tail(),
> this reuse effect can't be obtained without using all of them.
> For a longer-term solution, we should allocate hardware descriptors
> using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today.
> This patch uses list_add() instead of list_add_tail() for short-term
> solution.

Applied, thanks

-- 
~Vinod

[toc] | [next] | [standalone]

#1406020

Hi Vinod,

On Saturday 14 May 2016 13:27:31 Vinod Koul wrote:
> On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote:
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Current rcar_dmac_desc_put() is using list_add_tail() in order to
> > push used descriptor to list of free descriptors, and next DMA transfer
> > try to reuse it from this list. But because it is using *_tail(),
> > this reuse effect can't be obtained without using all of them.
> > For a longer-term solution, we should allocate hardware descriptors
> > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today.
> > This patch uses list_add() instead of list_add_tail() for short-term
> > solution.
> 
> Applied, thanks

Thanks, but where did you apply it to ? I can't find it in your tree.

-- 
Regards,

Laurent Pinchart

[toc] | [prev] | [next] | [standalone]

#1407598

On Tue, May 24, 2016 at 12:50:28PM +0300, Laurent Pinchart wrote:

Hey Laurent,

> On Saturday 14 May 2016 13:27:31 Vinod Koul wrote:
> > On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > Current rcar_dmac_desc_put() is using list_add_tail() in order to
> > > push used descriptor to list of free descriptors, and next DMA transfer
> > > try to reuse it from this list. But because it is using *_tail(),
> > > this reuse effect can't be obtained without using all of them.
> > > For a longer-term solution, we should allocate hardware descriptors
> > > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today.
> > > This patch uses list_add() instead of list_add_tail() for short-term
> > > solution.
> > 
> > Applied, thanks
> 
> Thanks, but where did you apply it to ? I can't find it in your tree.

I changed my mind after this and felt that we should document above
in the changelog as well and replied to Kuninori few moments after this [1]

Sorry if that wasn't clear that am not applying this.

Please resend it with update changelog

[1]: http://www.spinics.net/lists/dmaengine/msg09585.html

-- 
~Vinod

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web