Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1406020

Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()

From Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups linux.kernel
Subject Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()
Date 2016-05-24 12:00 +0200
Message-ID <rChi2-1AN-31@gated-at.bofh.it> (permalink)
References <ruiuB-Vd-7@gated-at.bofh.it> <ruiuB-Vd-15@gated-at.bofh.it> <ryCEq-4qo-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Vinod,

On Saturday 14 May 2016 13:27:31 Vinod Koul wrote:
> On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote:
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Current rcar_dmac_desc_put() is using list_add_tail() in order to
> > push used descriptor to list of free descriptors, and next DMA transfer
> > try to reuse it from this list. But because it is using *_tail(),
> > this reuse effect can't be obtained without using all of them.
> > For a longer-term solution, we should allocate hardware descriptors
> > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today.
> > This patch uses list_add() instead of list_add_tail() for short-term
> > solution.
> 
> Applied, thanks

Thanks, but where did you apply it to ? I can't find it in your tree.

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Vinod Koul <vinod.koul@intel.com> - 2016-05-14 10:00 +0200
  Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-05-24 12:00 +0200
    Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Vinod Koul <vinod.koul@intel.com> - 2016-05-26 17:30 +0200

csiph-web